Question about Requesters

8 posts / 0 new

Last post

Fri, 2024-06-14 12:24

OldFart

Offline

Last seen: 15 hours 35 min ago

Joined: 2010-11-30 14:09

Question about Requesters

Hi,

When using a requester that has tag REQ_TimeOutSecs defined (with a value > 0) and subsequently the requester DOES time out, what is then the return value of the method? Do I correctly assume this to be 0? Or?

void VARARGS68K MessageBox(struct ExecParam *xn, ...)
{
INFO_ENTER
 
 va_list ap; 
 va_startlinear(ap, xn);
 IExec->RawDoFmt((__RD)->rd_FormatText, va_getlinearva(ap, void*), NULL, (__RD)->rd_BodyText);
 va_end(ap);
 
 struct TagItem  ReqTags[] = {{REQ_Type       ,         (__RD)->rd_Type}
                             ,{REQ_TitleText  , (uint32)(__RD)->rd_TitleText}
                             ,{REQ_GadgetText , (       (__RD)->rd_GadgetText) ? ((uint32)(__RD)->rd_GadgetText)
                                                                               : ((uint32)  INFO_GADGETTEXT)}
                             ,{REQ_BodyText   , (uint32)(__RD)->rd_BodyText}
                             ,{REQ_TimeOutSecs, (uint32)(__RD)->rd_TimeOut}
                             ,{REQ_Image      , (uint32)(__RD)->rd_Image}
                             ,{TAG_END        , (uint32)0}
                             };
 
 struct orRequest ReqMsg   = {RM_OPENREQ, ReqTags, (__RD)->rd_Window, (__RD)->rd_Screen};
 
 if (rd->rd_WinObj != NULL)
  {
   IIntuition->SetAttrs(*(__RD)->rd_WinObj, WA_BusyPointer, TRUE, TAG_END);
   (__RD)->rd_Response = IIntuition->IDoMethodA((__RD)->rd_ReqObj, (APTR)&ReqMsg);
   IIntuition->SetAttrs(*(__RD)->rd_WinObj, WA_BusyPointer, FALSE, TAG_END);
  }
 else
  {
   (__RD)->rd_Response = IIntuition->IDoMethodA((__RD)->rd_ReqObj, (APTR)&ReqMsg);
  }
 
INFO_VACATE
}

And now that I'm at it, how would tag 'Req_VarArgs' fit in here? Would this cut that cake?

void VARARGS68K MessageBox(struct ExecParam *xn, ...)
{
INFO_ENTER
 
 va_list ap; 
 va_startlinear(ap, xn);
 va_end(ap);
 
 struct TagItem  ReqTags[] = {{REQ_Type       ,         (__RD)->rd_Type}
                             ,{REQ_TitleText  , (uint32)(__RD)->rd_TitleText}
                             ,{REQ_GadgetText , (       (__RD)->rd_GadgetText) ? ((uint32)(__RD)->rd_GadgetText)
                                                                               : ((uint32)  INFO_GADGETTEXT)}
                             ,{REQ_VarArgs    , (uint32)va_getlinearva(ap, void*)}
                             ,{REQ_BodyText   , (uint32)(__RD)->rd_FormatText}
                             ,{REQ_TimeOutSecs, (uint32)(__RD)->rd_TimeOut}
                             ,{REQ_Image      , (uint32)(__RD)->rd_Image}
                             ,{TAG_END        , (uint32)0}
                             };
 
 struct orRequest ReqMsg   = {RM_OPENREQ, ReqTags, (__RD)->rd_Window, (__RD)->rd_Screen};
 
 if (rd->rd_WinObj != NULL)
  {
   IIntuition->SetAttrs(*(__RD)->rd_WinObj, WA_BusyPointer, TRUE, TAG_END);
   (__RD)->rd_Response = IIntuition->IDoMethodA((__RD)->rd_ReqObj, (APTR)&ReqMsg);
   IIntuition->SetAttrs(*(__RD)->rd_WinObj, WA_BusyPointer, FALSE, TAG_END);
  }
 else
  {
   (__RD)->rd_Response = IIntuition->IDoMethodA((__RD)->rd_ReqObj, (APTR)&ReqMsg);
  }
 
INFO_VACATE
}

And then, whilst going through 'classes/requester.h', I encountered that very sexy sounding tag 'REQ_StayOnTop'. I'll try and see how that one can be fitted in.

OldFart

Sat, 2024-06-15 08:55

msteed

Offline

Last seen: 2 months 3 days ago

Joined: 2022-01-18 08:34

Re: Question about Requesters

I can't help with REQ_VarArgs, as I've never played with that. But for the timeout, the autodoc says:

For all [requester] types, returns -1 when a timeout occured or when an IDCMP event specified with REQ_IDCMP_Ptr occurred.

Sat, 2024-06-15 11:11

(Reply to #2) #3

OldFart

Offline

Last seen: 15 hours 35 min ago

Joined: 2010-11-30 14:09

Re: Question about Requesters

@msteed

I missed that one. Thanks!

OldFart

Sat, 2024-06-15 11:56

thomas

Offline

Last seen: 2 days 11 hours ago

Joined: 2011-05-16 14:23

Re: Question about Requesters

I am quite sure that every reference to ap is illegal after va_end(ap) and also the result of va_getlinearva becomes invalid after va_end. So you have to move va_end to the end of your function, at least after DoMethod.

Sat, 2024-06-15 13:34

(Reply to #4) #5

OldFart

Offline

Last seen: 15 hours 35 min ago

Joined: 2010-11-30 14:09

Re: Question about Requesters

@thomas

I am quite sure that every reference to ap is illegal after va_end(ap) and also the result of va_getlinearva becomes invalid after va_end.

Sounds (and seems) logical. Thanks.

OldFart

Tue, 2024-06-18 00:57

jabirulo

Offline

Last seen: 3 weeks 5 days ago

Joined: 2013-05-30 00:53

Re: Question about Requesters

@OldFart

for the REQ_VarArgs, you can take a look in playcdda_gui.c (os4depot)
http://www.os4depot.net/share/audio/play/playcdda_gui.lha

or this one:

VARARGS68K VOID SV_Message(CONST_STRPTR text, ...)
{
	ULONG idcmp = 0L;
	struct EasyStruct estr;
	va_list args;
	ULONG *vargs = NULL;
 
#if defined(__amigaos4__)
	va_startlinear(args,text);
	vargs = va_getlinearva(args,ULONG *);
#else
	va_start(args,text);
	vargs = args;
#endif
 
	if(RequesterBase)
	{
		struct Screen *scr = LockPubScreen(NULL);
		Object *req = NewObject(RequesterClass, NULL,
						REQ_Image,      REQIMAGE_WARNING,
						REQ_TitleText,  GETMSG(MSG_AKDT_MESSAGE),
						REQ_BodyText,   text,
						REQ_VarArgs,    vargs,
						REQ_GadgetText, GETMSG(MSG_INFOWIN_OK),
					TAG_DONE);
		if(req)
		{
			//SETWINDOWBUSY(TRUE);
			IDoMethod(req, RM_OPENREQ, NULL, NULL, scr);
			//SETWINDOWBUSY(FALSE);
			DisposeObject(req);
		}
		UnlockPubScreen(NULL, scr);
		va_end(args);
		return;
	}
 
	if(!IntuitionBase) IntuitionBase = OpenLibrary("intuition.library", 37);
	if(!IntuitionBase) return;
 
	estr.es_StructSize   = sizeof(struct EasyStruct);
	estr.es_Flags        = 0L;
	estr.es_Title        = GETMSG(MSG_AKDT_MESSAGE);
	estr.es_TextFormat   = text;
	estr.es_GadgetFormat = GETMSG(MSG_OK);
 
	EasyRequestArgs(NULL, &estr, &idcmp, vargs);
 
	va_end(args);
}

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonRX550/SSD240GB/DVDRW :-P

Tue, 2024-06-18 16:53

(Reply to #6) #7

OldFart

Offline

Last seen: 15 hours 35 min ago

Joined: 2010-11-30 14:09

Re: Question about Requesters

@Jabirulo

Thanks!

OldFart

Thu, 2024-07-18 21:00

hypex

Offline

Last seen: 1 month 2 weeks ago

Joined: 2011-09-09 16:20

Re: Question about Requesters

@OldFart

I encountered that very sexy sounding tag

LOL. Also, if you are also to target DOS 51.12+, then you can use TimedDosRequester(). Which provides a similar but simpler function to display a similar requester.

Search form

User login