Populating Reaction Listbrowsers from a file?

11 posts / 0 new

Log in or register to post comments

Last post

Mon, 2011-11-28 14:16

#1

AmigaOneFan

AmigaOneFan's picture

Offline

Last seen: 11 years 3 weeks ago

Joined: 2011-11-14 16:18

Populating Reaction Listbrowsers from a file?

Hi,

I have a function called make_browserlist as follows:

BOOL make_browserlist(struct List *list, char **tagstring, int columns)
{
    struct Node *node;
 
    IExec->NewList(list);
 
    switch (columns)
    {
        case 2:
        while (*tagstring)
        {
            if (node = IListBrowser->AllocListBrowserNode(columns,
                LBNA_Column, 0,
                    LBNCA_Text, *tagstring++,
                LBNA_Column, 1,
                    LBNCA_Text, *tagstring++,
                TAG_DONE))
            {
                IExec->AddTail(list, node);
            }
            else
            {
                IDOS->Printf(" AllocListBrowserNode() failed\n");
                return(FALSE);
            }
       }
 
        case 3:
        while (*tagstring)
        {
            if (node = IListBrowser->AllocListBrowserNode(columns,
                LBNA_Column, 0,
                    LBNCA_Text, *tagstring++,
                LBNA_Column, 1,
                    LBNCA_Text, *tagstring++,
                LBNA_Column, 2,
                    LBNCA_Text, *tagstring++,
                TAG_DONE))
            {
                IExec->AddTail(list, node);
            }
            else
            {
                IDOS->Printf(" AllocListBrowserNode() failed\n");
                return(FALSE);
            }
       }
 
        case 5:
        while (*tagstring)
        {
            if (node = IListBrowser->AllocListBrowserNode(columns,
                LBNA_Column, 0,
                    LBNCA_Text, *tagstring++,
                LBNA_Column, 1,
                    LBNCA_Text, *tagstring++,
                LBNA_Column, 2,
                    LBNCA_Text, *tagstring++,
                LBNA_Column, 3,
                    LBNCA_Text, *tagstring++,
                LBNA_Column, 4,
                    LBNCA_Text, *tagstring++,
                TAG_DONE))
            {
                IExec->AddTail(list, node);
            }
            else
            {
                IDOS->Printf(" AllocListBrowserNode() failed\n");
                return(FALSE);
            }
       }
 
            break;
 
        default:
                IDOS->Printf(" Invalid number of list fields\n");
                return(FALSE);
 
    };  // switch
 
   return(TRUE);
}

I can call this with static STRPTR string data and populate my listbrowsers fine.
However, I want to use char[] arrays that have strings I have retrieved from an input text file to populate my listbrowser lists using this same function.
I suspect I need to coerce my character arrays into static strings somehow. When I try to pass my char arrays into this function I always seem to get DSI errors no matter what I do. So for example I might do the following:

char mylist[1000];
...
  if(make_browserlist(&listbrowser_list1, mylist, 3)
   {
   // list made okay - continue with program
   }   
   else
   {
   IDOS-Printf("Error making browser list!\n");
   }

I am retrieving mylist using basic C fileio and verifying that the string data is actually populated in mylist.
Does mylist have to be global? I have tried calling make_browserlist with (char *)&mylist etc but always get the same result.

Thanks!

Mon, 2011-11-28 15:45

#2

Rigo

Rigo's picture

Offline

Last seen: 2 years 6 months ago

Joined: 2011-01-24 21:55

As you say, the file I/O

As you say, the file I/O routines do not return arrays of string pointers, they fill a user buffer with characters until EoF or CR.

You will need to take this buffer and manually copy each word in it into an array of STRPTRs in order to pass it to your function.

Alternatively, you can use FGetC() to retrieve one character from the file at a time and copy these while parsing for white space and newlines.

Simon

Tue, 2011-11-29 00:17

(Reply to #2) #3

AmigaOneFan

AmigaOneFan's picture

Offline

Last seen: 11 years 3 weeks ago

Joined: 2011-11-14 16:18

You will need to take this

<*>
You will need to take this buffer and manually copy each word in it into an array of STRPTRs in order to pass it to your function.

Yes...painful!
From what I can glean from playing with the GCC debugger, it looks like a STRPTR type is an array of pointers to static strings, each null (byte) terminated. So, for example:

STRPTR PageLabels[] =
{
   "Credit or Bank Cards",
   " Internet Passwords ",
   "  Other Passwords   ",
   " Insurance Policies ",
   NULL
};

really shows a series of four addresses, each of which I believe points to a static string in memory. Thus PageLabels[0] = 0x12345678 (an address in memory), which points to the null terminated static string "Credit or Bank Cards".

So is there an easier way to populate list browser strings from getline() file I/O?

Thanks

Tue, 2011-11-29 01:33

(Reply to #3) #4

Rigo

Rigo's picture

Offline

Last seen: 2 years 6 months ago

Joined: 2011-01-24 21:55

It really all depends on how

It really all depends on how your file is structured.

For example, an xml file would make it easier to read in the strings and place them in a list, which could then be used to create the listbrowser nodes.

To be honest, this conversation is far too general to try and offer any solutions. Specific problems are much easier to offer assistance with.

Simon

Tue, 2011-11-29 10:01

#5

trixie

trixie's picture

Offline

Last seen: 7 months 3 weeks ago

Joined: 2011-02-03 13:58

Re: Populating Reaction Listbrowsers from a file?

@ AmigaOneFan

Not that it answers your questions but anyway: I've found it easier and safer to use "LBNCA_CopyText, TRUE" when populating a listbrowser list from string pointers.

AmigaOne X5000-020 / 2GB RAM / Sapphire Pulse Radeon RX 560 / AmigaOS 4.1 Final Edition Update 2

Tue, 2011-11-29 21:47

(Reply to #5) #6

AmigaOneFan

AmigaOneFan's picture

Offline

Last seen: 11 years 3 weeks ago

Joined: 2011-11-14 16:18

Hi Simon, Yes, I haven't

Hi Simon,

Yes, I haven't given a lot of specifics. Thankfully, I have found a solution, not really elegant but it works! You can find my updated source code here: http://www.os4coding.net/source/162

Since we are using arrays of string pointers, here is a way I populate the data from getline file I/O:

void LoadFile()
{
FILE *Infile;
u_char length1,length2,length3,length4;
char mystring[100];
 
int i,j;
 
      Infile = fopen("AmiSafe.dat", "r");
       if(Infile == 0)
         {
         MessageBox("UhOh!","Unable to open AmiSafe.dat input file!");
         }
         else   // read in parameter data
         {
 
// Read Tab #1 Info
            length1 = fgetc(Infile);
#ifdef DEBUG
            IDOS->Printf("Tab 1 has %lu entries\n",length1);
#endif
            IExec->NewList((struct List *)&listbrowser_list1);
 
            i = 0;
            while(length1 > 0)
            {
                j = COLSTAB1;
                while(j > 0)
                {
                   fgets(mystring, 100, Infile); 
                   mystring[strlen(mystring)-1] = 0;  // convert \n to 0
                   strcpy(Tab1Strings[i++], mystring);
                   j--;
                }
                length1--;
            }
            Tab1Strings[i] = 0;   // add tail null
...

I get the string and put it into mystring temporarily, convert the trailing \n into a nul, then copy it to Tab1Strings, which is defined as follows:

#define STRSIZE 40
#define MAXENTRIES 100
#define COLSTAB1 5
#define COLSTAB2 3
#define COLSTAB3 2
#define COLSTAB4 3
 
// Arrays of text data for each tab
STRPTR Tab1Strings[MAXENTRIES];
STRPTR Tab2Strings[MAXENTRIES];
STRPTR Tab3Strings[MAXENTRIES];
STRPTR Tab4Strings[MAXENTRIES];

It is VITALLY IMPORTANT to be sure to malloc the memory I intend to use to store the strings, which I do in my main function prior to calling the LoadFile function that populates the strings:

        // Allocate Space for Strings + 1 for nul for all tabs
        for(i = 0; i < MAXENTRIES; i++)
        {
            Tab1Strings[i] = malloc((STRSIZE + 1)*sizeof(char));
            Tab2Strings[i] = malloc((STRSIZE + 1)*sizeof(char));
            Tab3Strings[i] = malloc((STRSIZE + 1)*sizeof(char));
            Tab4Strings[i] = malloc((STRSIZE + 1)*sizeof(char));        
            }

I also am sure to free this memory upon closing the program. I could simply allocate the memory for each string as I use it and save a few thousand bytes of RAM, but this is a quick and dirty way to ensure I have all the space I need without worrying about malloc and free for every string populate and delete I will do.

So my AmiSafe.c program right now loads in a file of data, populates the list browsers for the four tabs of information from this file data, allows the user to edit in place the content of the strings, then (if you select the HELP button, for now) writes out the data in a format usable by the program in the amisafe.dat file.
Now all I need to do is come up with a way to add a new entry, delete a selected entry, and then add a 4x4 button matrix at startup to allow the user to create and use a password, then incorporate the RIJNDAEL algorithm to encode and decode the file data.
Easy.....I hope!

I hope this source and program helps others who want to do similar things in REACTION listbrowsers.

Tue, 2011-12-20 16:38

#7

AmigaOneFan

AmigaOneFan's picture

Offline

Last seen: 11 years 3 weeks ago

Joined: 2011-11-14 16:18

Okay, now a slightly

Okay, now a slightly different subject....

I am adding new data to a listbrowser by creating a new node and calling AddTail.
How do I update the display and the listbrowser attributes for this new entry? I'm sure there is some simple way to do this.....

Thanks!

Tue, 2011-12-20 20:24

(Reply to #7) #8

Rigo

Rigo's picture

Offline

Last seen: 2 years 6 months ago

Joined: 2011-01-24 21:55

To make any changes to the

To make any changes to the list currently displayed, you first have to detach the list by calling

SetAttrs( listbrowserobj, LISTBROWSER_Labels, NULL, TAG_DONE );

Then you can make your changes (adding, removing or changing attributes). Once that is done, you reattach the list. Depending on how you do this depends on whether the list gets updated visually.
If you use SetAttrs() you will need to manually referesh the gadget afterwards. Luckily, the list can be set like so:

SetGadgetAttrs( listbrowserobj, window, NULL, LISTBROWSER_Labels, labelist, TAG_DONE );

and this will refresh the gadget for you. You might want to check out the listbrowser examples in the Examples directory of the SDK, all this is covered quite nicely.

Simon

Fri, 2011-12-23 00:55

(Reply to #8) #9

AmigaOneFan

AmigaOneFan's picture

Offline

Last seen: 11 years 3 weeks ago

Joined: 2011-11-14 16:18

Hmmm... I manage to

Hmmm...

I manage to deadlock the system (I think) when I do this. Here's what I am doing, please feel free to point out my foolish mistakes!

// Detach the listbrowser list first
    IIntuition->SetAttrs((struct Gadget*)OBJ(OBJ_LISTBROWSER1), 
    LISTBROWSER_Labels, NULL, TAG_DONE);
...
 change my attributes and add to the end of my labels browserlist here...
...
 
/* Using RefreshSetGadgetAttrs() is required to force intuition
* to refresh the gadget imagery.
*/
        IIntuition->RefreshSetGadgetAttrs((struct Gadget*)OBJ(OBJ_LISTBROWSER1), 
        window, NULL,
        LISTBROWSER_Labels, &browserlist,
        TAG_DONE);

What am I doing wrong?

Fri, 2011-12-23 14:03

(Reply to #9) #10

Rigo

Rigo's picture

Offline

Last seen: 2 years 6 months ago

Joined: 2011-01-24 21:55

It can only be an invalid

It can only be an invalid pointer, everything else looks fine (what there is of it).

Simon

Fri, 2011-12-23 10:29

(Reply to #10) #11

trixie

trixie's picture

Offline

Last seen: 7 months 3 weeks ago

Joined: 2011-02-03 13:58

Re: Populating Reaction Listbrowsers from a file?

@AmigaOneFan

Your use of type casts looks a little awkward there. OBJ(OBJ_LISTBROWSER1) should have been declared as a pointer to Object so you don't need to cast it to struct Gadget* in SetAttrs(). The correct line would be:

IIntuition->SetAttrs(OBJ(OBJ_LISTBROWSER1), LISTBROWSER_Labels, NULL, TAG_DONE);

SetGadgetAttrs() and RefreshSetGadgetAttrs(), on the other hand, expect their first argument to be a struct Gadget pointer (instead of an Object pointer) so the type cast is appropriate.

In your particular example, not much harm will be done but be careful about unnecessary type casting, it may cause trouble elsewhere.

AmigaOne X5000-020 / 2GB RAM / Sapphire Pulse Radeon RX 560 / AmigaOS 4.1 Final Edition Update 2

Log in or register to post comments