TextLength()

20 posts / 0 new

Last post

Wed, 2015-12-23 06:34

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

TextLength()

I am trying to get the longest length of some strings. It is working

int32
SAK_LongestStrLenPixels(int32 From,int32 To)
{
	STRPTR				Text;
	int32				MaxLen=0, Len, i;
 
	for (i=From; i<=To; i++)
	{
		if ((Text=SAK_LocaleString(i)))
		{
			if ((Len=IGraphics->TextLength(MainWindow->RPort,Text,IUtility->Strlen(Text)))>MaxLen)
				MaxLen=Len;
		}
	}
 
	return(MaxLen);
}

Except it is not using MainWindow's font, which is proportional. It is using the system default font, which is mono spaced. I am not assigning a different font for my window, why isn't it using the correct one to measure the lengths?

Wed, 2015-12-23 17:35

gazelle

Offline

Last seen: 1 year 9 months ago

Joined: 2011-04-13 12:52

Re: TextLength()

You're not using a GimmeZeroZero window by chance?

from intuition.library/OpenWindow:

BUGS
When you open a window, Intuition will set the font of
the window's RastPort to the font of the window's screen.
This does not work right for GimmeZeroZero windows: the
BorderRPort RastPort has the font set correctly, but
Window.RPort is set up with the system default font.
For compatibility reasons, we won't be fixing this problem.

Wed, 2015-12-23 23:19

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

Re: TextLength()

Nope. Using window.class to create/layout the guts.

Thu, 2015-12-24 00:46

(Reply to #3) #4

jabirulo

Offline

Last seen: 2 weeks 4 days ago

Joined: 2013-05-30 00:53

Re: TextLength()

And your 'MainWindow' struct what Font (struct TextFont *IFont;) is using?
Maybe you can post your window creation code, in case misssing some tag.

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Thu, 2015-12-24 02:14

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

Re: TextLength()

	if (!(Objects[OID_WINDOW]=IIntuition->NewObject(IWindow->WINDOW_GetClass(),NULL,
		WA_PubScreen,		DefaultPubScreen,
		WA_Title,			WindowTitle,
		WA_Left,			Prefs->WindowX+(10*(PortNumber-1)),
		WA_Top,				Prefs->WindowY+(10*(PortNumber-1)),
		WA_Width,			Prefs->WindowWidth,
		WA_Height,			Prefs->WindowHeight,
		WA_Flags,			WFLG_CLOSEGADGET | WFLG_DRAGBAR | WFLG_DEPTHGADGET | WFLG_SIZEBBOTTOM | WFLG_SIZEGADGET | WFLG_ACTIVATE,
		WA_IDCMP,			IDCMP_MENUPICK | IDCMP_RAWKEY | IDCMP_EXTENDEDMOUSE | IDCMP_MOUSEBUTTONS | IDCMP_DISKINSERTED | IDCMP_DISKREMOVED | IDCMP_NEWSIZE | IDCMP_CHANGEWINDOW,
		WINDOW_UniqueID,	PortBuffer,
		WINDOW_AppPort,		UserPort,
		WINDOW_PopupGadget,	TRUE,
		WINDOW_JumpScreensMenu,	TRUE,
		WINDOW_AppWindow,	TRUE,
		WINDOW_AppMsgHook,	appMsgHook,
		WINDOW_IconifyGadget,	TRUE,
		WINDOW_GadgetHelp,		TRUE,
		WINDOW_IDCMPHook,		idcmpHook,
		WINDOW_IDCMPHookBits,	IDCMP_IDCMPUPDATE | IDCMP_RAWKEY | IDCMP_EXTENDEDMOUSE | IDCMP_MOUSEBUTTONS | IDCMP_DISKINSERTED | IDCMP_DISKREMOVED,
		WINDOW_Layout,		Objects[OID_LAYOUT]=IIntuition->NewObject(ILayout->LAYOUT_GetClass(),NULL,

DefaultPubScreen is NULL, so Workbench.

Thu, 2015-12-24 03:22

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

Re: TextLength()

Figured it out. I should be looking at the screen's RastPort, not the window. Which makes sense so I can get the max text length to build the gadgets before opening the window.
if ((Len=IGraphics->TextLength(&DefaultPubScreen->RastPort,Text,IUtility->Strlen(Text)))>MaxLen)

Thu, 2015-12-24 17:34

(Reply to #6) #7

hypex

Offline

Last seen: 3 months 2 weeks ago

Joined: 2011-09-09 16:20

Re: TextLength()

That's interesting. When I want to get text length of strings I last used IntuiTextLength().

Fri, 2015-12-25 11:52

(Reply to #7) #8

OldFart

Offline

Last seen: 3 months 1 week ago

Joined: 2010-11-30 14:09

Re: TextLength()

@mritter0:

Nitpicking, but from the snippet of code you supplied it shows that, per NewObject()-call, you are (still) using the GetClass()-function as supplied by the class itself. As of V50 this is deprecated practice. See the Autodoc below, regarding this topic.

OldFart

intuition.library/OpenClass                           intuition.library/OpenClass
 
    NAME
	OpenClass -- Open a diskbased BOOPSI class. (V50)
 
    SYNOPSIS
	struct ClassLibrary *result = OpenClass(CONST_STRPTR name, uint32 version,
	                                        Class **class_ptr);
 
    FUNCTION
	This function can be used to open a disk-based BOOPSI class. It works
	like exec.library/OpenLibrary() but also returns a pointer to the class.
 
	Use of this function can eliminate the need for getting the class
	interface and using the deprecated *_GetClass() functions.
 
    INPUTS
	name      - Name of the BOOPSI class to open
	            (including possible path prefix like "gadgets/" or "images/").
	version   - Minimum version of the class required.
	class_ptr - Pointer to a Class pointer.
	            Use this pointer with NewObject().
 
    RESULT
	result - Pointer to the ClassLibrary base or NULL on error.
 
    NOTES
	Take care this function may fail miserably when the class
	doesn't use a struct ClassLibrary * base!
 
    SEE ALSO
	CloseClass(), NewObject()

Sat, 2015-12-26 04:16

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

Re: TextLength()

Previously I posted a question on Hyperion Forum and Steven Solie said that the Reaction macros are GOING to be deprecated so don't use them. Fine. Go into reaction_macros.h and replace the #define shortcut with the code it represents (in my code). That is the code.

What should I be using then for the window and gadgets?

Edit: I am opening the class before this.

	WindowBase=IExec->OpenLibrary("window.class",54);
	if (!WindowBase || !LIB_IS_AT_LEAST((struct Library *)WindowBase,54,1))
	{
		SAK_EasyRequest(Objects[OID_WINDOW],MainWindow,RequesterTitle,REQIMAGE_ERROR,0,SAK_LocaleString(MSG_LIBS_COULD_NOT_OPEN_X_CLASS),SAK_LocaleString(MSG_TERMINATE),"Window",54,1);
 
		return(FALSE);
	}
	IWindow=(struct WindowIFace *)IExec->GetInterface(WindowBase,"main",1,NULL);

Sat, 2015-12-26 12:07

(Reply to #9) #10

OldFart

Offline

Last seen: 3 months 1 week ago

Joined: 2010-11-30 14:09

Re: TextLength()

@mritter0:

Here's an idea about how to do:

//	WindowBase=IExec->OpenLibrary("window.class",54);
	WindowBase=Intuition->OpenClass("window.class",54, &WindowClass);
	if (!WindowBase || !LIB_IS_AT_LEAST((struct Library *)WindowBase,54,1))
	{
		SAK_EasyRequest(Objects[OID_WINDOW],MainWindow,RequesterTitle,REQIMAGE_ERROR,0,SAK_LocaleString(MSG_LIBS_COULD_NOT_OPEN_X_CLASS),SAK_LocaleString(MSG_TERMINATE),"Window",54,1);
 
		return(FALSE);
	}
	IWindow=(struct WindowIFace *)IExec->GetInterface(WindowBase,"main",1,NULL);
 
        Object *MyWindow = IIntuition->NewObject(WindowClass, NULL, ....., TAG_END);
 
        .
        .
        etc.,
        etc.,
        .
        .
 
        IIntuition->CloseClass(WindowBase);

An excellent tutorial about this subject by Trixie you can find HERE. This is a very good read and is highly endorsed!

About the ReAction macro's: my perception about them is that they are absolute crap and severly contribute to ReAction's infamous image. Avoid them! They should have been deprecated decades ago if ever introduced. Anything you create yourself in that respect will PROBABLY suit you better then those macro's. But, as I said already: this is MY perception.

OldFart

Sat, 2015-12-26 21:51

(Reply to #10) #11

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

Re: TextLength()

About the ReAction macro's: my perception about them is that they are absolute crap and severly contribute to ReAction's infamous image. Avoid them! They should have been deprecated decades ago if ever introduced. Anything you create yourself in that respect will PROBABLY suit you better then those macro's. But, as I said already: this is MY perception.

AFAIK the WindowObject, VGroupObject, etc. macros are inspired by MUI which has very similar macros for GUI creation.

Sun, 2015-12-27 21:48

#12

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

Re: TextLength()

@OldFart: Nit picks are fine with me. I want it right. Thanks. Updated it. I kind of had it that way back when I first started my project on OS3.9. OpenClass() isn't there so I was using someone's custom class opener.

I read Trixie's post but it didn't "click" that I still needed to update my code to OS4 since it was working.

Trixie does struct ClassLibrary * and I started with that but get redefined errors because the classes are still struct Library * in the proto header files (proto/chooser.h for example). Instead of casting them, just update them in the SDK. I would rather be "forced" to update my code so I know it will work in the future and be more stable in the present.

People say don't use the ReAction macros anymore. Some say don't use libauto anymore. I was told (suggested) to not use __USE_INLINE__ anymore. Most (if not all) of the SDK examples follow any of these suggestions. Even the new MenuClass example is using old code. If the core developers aren't doing things the way they tell us we should be doing it, how are we supposed to know what to do? If the examples supplied to us are outdated, how are we to know about newer functions?

There is an obsolete file for DOS functions. Make one for every library and get people in the habit of updating their code. Better yet, don't let the obsolete file update their code without their knowledge, just throw an error. But make a large, global, obsolete file in the root of the SDK with the new functions to use instead. It wouldn't bother me at all to update my code, but I have to know there is a file to look at to see what to use now.

Just do it. Force programmers to update their code and "do it the right way." Backwards compatibility can only go so far.

Mon, 2015-12-28 09:40

(Reply to #12) #13

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

Re: TextLength()

@mritter0

Trixie does struct ClassLibrary * and I started with that but get redefined errors because the classes are still struct Library * in the proto header files (proto/chooser.h for example).

FWIW I'm considering changing the proto header files' extern definitions for class libraries to struct ClassLibrary * but as this change will probably break a lot of existing code I'd like to have some input from other developers first before making such a change. Also it will cause problems for programs that need to be compiled for both older and newer AmigaOS so some kind of define to switch back to the old struct Library * definition might be in order.

As is currently you can either define your library base globals as struct Library * and add casting in your OpenClass()/CloseClass() calls or define __NOLIBBASE__ to disable the proto file extern definition.

Wed, 2015-12-30 18:45

(Reply to #13) #14

xenic

Offline

Last seen: 2 years 6 months ago

Joined: 2011-05-07 04:52

Re: TextLength()

@mritter
While everyone else is concerned with the use of macros, I'm wondering if using the screen's font is the right choice. Since you appear to be concerned about gadget text, what happens if the user has set custom fonts & font sizes in the "GUI preferences/Gadgets/General" tab? Will that affect your use of the screen font to calculate text lengths??

X1000 - OS 4.1FE

Thu, 2015-12-31 00:17

#15

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

Re: TextLength()

@xenic: Yes, gadget text is what I want to account for. But since the window is not open yet the default screen font is all I can look at. Unless there is something else.....

@salass00: I hope I didn't sound too rash/harsh. The OS is almost too flexible. Some things just need to forced to be done a certain way, while simple other things (labels, images) can still have some of the nice flexibility.

Thu, 2015-12-31 16:55

(Reply to #15) #16

thomas

Offline

Last seen: 3 months 6 days ago

Joined: 2011-05-16 14:23

Re: TextLength()

A gadget class in a ReAction GUI gets its GM_DOMAIN method called with a RastPort set up properly for layout. There is no need to look at other font sources.

Thu, 2015-12-31 17:54

(Reply to #16) #17

xenic

Offline

Last seen: 2 years 6 months ago

Joined: 2011-05-07 04:52

Re: TextLength()

Yes, gadget text is what I want to account for. But since the window is not open yet the default screen font is all I can look at. Unless there is something else.....

There is GUIA_GadgetTextAttr & GUIA_LabelTextAttr in SDK:Include/include_h/intuition/gui.h but I've never attempted to get any of those settings myself.

X1000 - OS 4.1FE

Fri, 2016-01-01 01:07

#18

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

Re: TextLength()

@Thomas: Finding size of system font

In your reply #2 you say to use the screen font. If not, then what are the ReAction classes using to find the correct font and size?

@xenic: GUIA_GadgetTextAttr is probably what I need. I was just reading the gui.h and says to not access them unless have a really good reason. Guess it wouldn't hurt to read them, just not write to them.

Fri, 2016-01-01 17:43

(Reply to #18) #19

xenic

Offline

Last seen: 2 years 6 months ago

Joined: 2011-05-07 04:52

Re: TextLength()

@mritter

GUIA_GadgetTextAttr is probably what I need. I was just reading the gui.h and says to not access them unless have a really good reason. Guess it wouldn't hurt to read them, just not write to them.

You really don't want to override user preferences, so those GUI attributes should only be read. I was wrong about never having used them myself. I modified an old 'personal-use' gadtools program to use the same gadget fonts as Reaction so it would be more readable. Here is a snippet of code I used:

struct TextAttr *sysfontTA = NULL;
struct DrawInfo *sdi;
uint32 result = 0;
 
sdi = IIntuition->GetScreenDrawInfo(screen);
if (sdi)
{
	result = IIntuition->GetGUIAttrs(NULL,sdi,GUIA_GadgetTextAttr,
	                                          &sysfontTA, TAG_END);
    IIntuition->FreeScreenDrawInfo(screen,sdi);
}
 
if ((result < 1) || (!sysfontTA))
{
	result = IIntuition->GetScreenAttr(screen, SA_Font, &sysfontTA,
	                                   sizeof(sysfontTA));
}

X1000 - OS 4.1FE

Sun, 2016-01-03 23:18

#20

mritter0

Offline

Last seen: 2 years 5 months ago

Joined: 2014-04-21 21:15

Re: TextLength()

@xenic: Updated my code with a mix of yours and mine. Works just fine. Thanks.

Search form

User login