AllocSysObject ???

7 posts / 0 new

Log in or register to post comments

Last post

Mon, 2015-01-12 21:31

#1

JosDuchIt

JosDuchIt's picture

Offline

Last seen: 8 years 3 weeks ago

Joined: 2012-01-08 20:57

AllocSysObject ???

The source below is compiled with

gcc guis:Dev/Gui4Cli_Dev/G4C_18/piper.c -gstabs -lauto -N -o g18:piper
and gives no errors or warnings.

The debug print statements observed are indicated with "seen"

int main(void) 
{
	LONG	 ProgRET=20, c ;///d
	BOOL rxmsgreplied=0; ///, wnmsgreplied, flag=0;
	char *buff=NULL;/// *gcdata=NULL;
	int stop=0; ///, comret, INTUIisopen=0;
	struct RexxMsg			*rxmsg = NULL;
	struct g4cmsg			*gcmess= NULL;
	struct Remember *rkey=NULL; 
	struct LaunchMessage *lmess; ///used also with xPIPE handling
	char *pt; ///*gp=NULL, *pt;
	///struct GCmain *gd=NULL;
	strcpy (myportname, "Gui4Cli");			// * name of default port * /
	RexxSysBase = OpenLibrary ("rexxsyslib.library",45);  //changed 
	if (RexxSysBase)
		IRexxSys = (APTR)GetInterface(RexxSysBase, "main", 1L, NULL); //changed 
	else PutStr("no RexxSysBase"); // not seen
	if (!(gd = (struct GCmain *)AllocRemember (&rkey, sizeof(struct GCmain), MEMF_CLEAR))) /// IIntuition->
	{	PutStr("no GCmain obtained\n"); //not seen
		goto endprog;
	}
 
	initgd ();	
 
// ------------------------ get main buffers -----------------------
 
	if (!(getbuffers(gd->buffsize, 0)))
	{	PutStr("no buff obtained\n"); /// IDOS->  //not seen
		goto endprog;
	}
	buff = gd->membuff[0];
// *------------------- Get default console ---------------------* /
 
// *------------------------- PASS to other Gui4Cli if running -----------* /
 
// *---------------------- Open Message ports ----------------------* /
 
// *------------------------ Open other libs etc.. -----------------------* /
if ( ! IntuitionBase || !UtilityBase   ) goto endprog; 
if ( ! IIntuition    || !IUtility      ) goto endprog;
if ( ! DOSBase       ) goto endprog; 
if ( ! IDOS          ) goto endprog;
if ( ! RexxSysBase   ) goto endprog;
if ( ! IRexxSys      ) goto endprog;
 
Dp(PutStr("Main 7\n")); //seen 
Dp(Printf ("Findport %s \n", myportname)); /// Findport Gui4Cli seen
	Forbid (); //IExec-> taskscheduler 
	if (FindPort(myportname)==NULL)
	{
Dp(Printf ("Findport %s \n", myportname)); /// Findport Gui4Cli Seen 
		myrxport=AllocSysObjectTags(ASOT_PORT, ASOPORT_Name, myportname, TAG_END); /// IExec->
	}
	Permit(); /// IExec->
	if (!myrxport)
	{	Printf ("%s could not create myPorts\n", myportname); /// SEEN ???
		ProgRET = 20;
		goto endprog;
	}

I don't understand what could go wrong with the AllocSysObject here (copied from a source where it works oK.

What other tests could i add before these last lines ??

Tue, 2015-01-13 00:11

#2

LyleHaze

LyleHaze's picture

Offline

Last seen: 2 years 1 month ago

Joined: 2011-05-26 03:58

Is it possible that you have

Is it possible that you have run out of signals?
The default for AllocSysObject(ASOT_PORT...) is to allocate a signal. If this allocation fails, I would expect the AllocSysObject() to fail as well.

Just one suggestion, but that would explain why the same code worked elsewhere but not here.

Good Luck!
LyleHaze

LyleHaze

Tue, 2015-01-13 00:59

#3

Ami603

Ami603's picture

Offline

Last seen: 6 years 7 months ago

Joined: 2011-10-11 23:11

I'm not sure the

I'm not sure the AllocSysObject Call can work inside a pair of Forbid()/Permit() calls?

Tue, 2015-01-13 10:19

(Reply to #3) #4

salass00

salass00's picture

Offline

Last seen: 7 months 1 day ago

Joined: 2011-02-03 11:27

Rather than putting the whole

Rather than putting the whole AllocSysObjectTags() call within Forbid()/Permit() you might want to do it like this:

struct MsgPort *port, *oldport;
port = AllocSysObjectTags(ASOT_PORT,
    ASOPORT_Name, portname,
    ASOPORT_Public, FALSE,
    TAG_END);
 
/* Add port only if no existing port of same name */
Forbid();
if ((oldport == FindPort(portname)) == NULL) {
    AddPort(port); 
}
Permit();
 
/* Delete port and set to NULL if there was already a port by that name */
if (oldport != NULL) {
    FreeSysObject(ASOT_PORT, port);
    port = NULL;
}

As mentioned one reason the port allocation might fail is that all your task's user signals are already allocated (there are 16 of them). To check for this you might want to add a debug statement like this before the AllocSysObjectTags() call:

Printf("tc_SigAlloc: 0x%lx\n", FindTask(NULL)->tc_SigAlloc);

Tue, 2015-01-13 12:20

(Reply to #4) #5

JosDuchIt

JosDuchIt's picture

Offline

Last seen: 8 years 3 weeks ago

Joined: 2012-01-08 20:57

@salass00 I started adding

@salass00

I started adding your printf statement

8.Stock:Backup_Datas/Gui4Cli/Dev/Gui4Cli_Dev/G4C_18> piper
Main 7
Findport Gui4Cli 
Findport Gui4Cli 
tc_SigAlloc: 0xFFFF    >>>>>>>>
Gui4Cli could not create gdPorts

Is this correct or faulty ?

Anyway i found out that completing the initgd() function a bit more (adding the last line -presnt in the original

void initgd()
{
	gd->tab = 8;                // tab size
	gd->buffsize = 1024;    // old gd->buffsize
	// -------------------------- Message Ports ---------------------------
	gd->myself = (struct Process *)FindTask(NULL);
	gd->sendport = AllocSysObject (ASOT_PORT, TAG_END); 
}

seemed to solve the problem

I now get

.Stock:Backup_Datas/Gui4Cli/Dev/Gui4Cli_Dev/G4C_18> piper
Main 7
Findport Gui4Cli 
Findport Gui4Cli 
tc_SigAlloc: 0x8000FFFF
launch.h/launch_piper NoDbgOutput pipename pipe:MyPipe

The source changed with the improved intigd() and the additioanl debug Printf suggested
allready detects the presence of an axisting Gui4Cli port and exits upon its detection

8.Stock:Backup_Datas/Gui4Cli/Dev/Gui4Cli_Dev/G4C_18> piper
Main 7
Findport Gui4Cli 
Gui4Cli could not create myPorts
8.Stock:Backup_Datas/Gui4Cli/Dev/Gui4Cli_Dev/G4C_18>

giving the intended error message

Thanks to all for help

Tue, 2015-01-13 13:30

(Reply to #5) #6

salass00

salass00's picture

Offline

Last seen: 7 months 1 day ago

Joined: 2011-02-03 11:27

So the problem is solved

So the problem is solved now?

If all user signals were allocated the value of tc_SigAlloc would have been 0xFFFFFFFF. The low 16 bits are signals reserved for system use so they will always be allocated.

Also don't call Printf() or other dos.library/file I/O functions while in Forbid() as they will Wait() causing the forbid state to be broken.

Thu, 2015-01-15 22:21

(Reply to #6) #7

JosDuchIt

JosDuchIt's picture

Offline

Last seen: 8 years 3 weeks ago

Joined: 2012-01-08 20:57

@salass00 So the problem is

@salass00

So the problem is solved now?

Yes, but it is not the last problem i have with this source.
thanks for suggestions

Log in or register to post comments