comparison is always true due to limited range of data type

3 posts / 0 new

Last post

Tue, 2012-07-31 13:04

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

comparison is always true due to limited range of data type

The code I'm compiling (not written by me) has a macro for checking a version number and then doing something if the version falls within the specified limits:

#define VER(file_version, first_version, last_version, block)\
	if ((((Uint16)file_version) >= ((Uint16)first_version)) && (((Uint16)file_version) <= ((Uint16)last_version)))\
	{\
		block;\
	}

The file_version passed in is an Uint8 and in some cases where this macro is used there is no upper limit for it so last_version is specified as 0xff so that the "file_version <= last_version" comparison will always be true. This is not a bug and is the wanted behavior but unfortunately gcc with -Wall refuses to shut up about it (I also use -Werror because I don't want to miss any warnings that might be bugs).

ppc-amigaos-gcc -std=gnu99 --no-strict-aliasing -O2 -Wall -Werror -I. -I/SDK/local/common/include/SDL -c -o snd/music.o snd/music.c
cc1: warnings being treated as errors
snd/music.c: In function 'load_wavetable_entry':
snd/music.c:1525: warning: comparison is always true due to limited range of data type
snd/music.c:1526: warning: comparison is always true due to limited range of data type
snd/music.c:1527: warning: comparison is always true due to limited range of data type
snd/music.c:1528: warning: comparison is always true due to limited range of data type
snd/music.c:1529: warning: comparison is always true due to limited range of data type
--- snip ---

Obviously the author of the code has tried to get around this warning by casting both values to Uint16 before doing this comparison but it seems that gcc 4.2.4 is "smart" enough to see through this ruse. I've tried adding "-Wno-type-limits" to stop this nonesense but unfortunately it is only supported in gcc >= 4.3 while the SDK gcc is version 4.2.4.

So does anyone know of an easy way to get around this apart from removing -Wall or -Werror options? Changing every invocation of the VER() macro in the code is not an option...

Tue, 2012-07-31 13:22

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

Well I got around the problem

Well I got around the problem by defining a static inline function for doing the comparison and then using it inside the VER() macro like so:

static inline bool _check_ver_(Uint16 file_version, Uint16 first_version, Uint16 last_version)
{
	return (file_version >= first_version) && (file_version <= last_version);
}
 
#define VER(file_version, first_version, last_version, block)\
	if (_check_ver_(file_version, first_version, last_version))\
	{\
		block;\
	}

Now I just wonder at which version gcc will be "smart" enough to see through this workaround...

Tue, 2012-07-31 22:24

(Reply to #2) #3

OldFart

Offline

Last seen: 3 months 1 week ago

Joined: 2010-11-30 14:09

@salass00 Clobbered this one

@salass00

Clobbered this one together:

#include <proto/exec.h>
#include <proto/dos.h>
 
#define VER(file_version, first_version, last_version)         \
   {uint16 file = file_version, first = first_version, last = last_version; \
	if (                                                       \
        (file >= first) && \
        (file <=  last)    \
        )                                                      \
	     {IDOS->Printf("INFO : Fileversion within limits\n");} \
    else {IDOS->Printf("ERROR: Fileversion out of limits\n");}}\
 
 
int main(int argc UNUSED, char *argv[] UNUSED)
{
  int RC = RETURN_FAIL;
 
  uint8 version[4] = {3, 1, 2, 4};
 
  VER(version[0], version[1], 0xff); //version[2]);
 
  VER(version[0], version[3], 0xff); //version[3]);
 
 
  return RC;
}

and compiled with this:

SWITCHES = -W                     \
           -Werror                \
           -Wmissing-prototypes   \
           -Wsign-compare         \
           -Wundef                \
           -Wshadow               \
           -Wwrite-strings        \
           -Wall
 
 
ProjecT : main.c
	gcc main.c -o ProjecT $(SWITCHES)
	@echo "=== Done making ================"

No more compile errors.

Output:

INFO : Fileversion within limits
ERROR: Fileversion out of limits

OldFart

Search form

User login