Small 68k asm conversion..

14 posts / 0 new

Last post

Tue, 2012-05-01 00:59

afxgroup

Offline

Last seen: 5 months 2 weeks ago

Joined: 2011-02-03 15:26

Small 68k asm conversion..

Hello,
Can anyone translate me this 68k code into C (or ppc asm..)

putreg(REG_D1, 0);
do {
	*bw = *(UWORD *)((UBYTE *)*plane-- + offset) >> shift;
	putreg(REG_A0, (long)bw);
	__emit(0xE4D0);	/* ROXR.W (A0) */
	__emit(0xE351);	/* ROXL.W #1,D1 */
	++bw;
}
while (--d > 0);

The first one seems a simply shift? or i ame wrong?

Tue, 2012-05-01 02:21

thomas

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-16 14:23

Well, it is not a "simple"

Well, it is not a "simple" shift because the bit which is shifted out on the right is moved into the X status bit. The second instruction shifts to the left and the new LSB is not just 0 but becomes the value of the X bit.

One could translate this into

X = (*A0) & 1; (*A0) >>= 1;
D1 = (D1 << 1) | X;

or a bit optimised

D1 = (D1 << 1) | ((*A0) & 1);
(*A0) >>= 1;

Wed, 2012-05-02 11:26

(Reply to #2) #3

afxgroup

Offline

Last seen: 5 months 2 weeks ago

Joined: 2011-02-03 15:26

unlucky it doesn't seems

unlucky it doesn't seems works as expected.. at least seeing the original 68k version..

But maybe could be this one the problem.

d = FloodDepth;
putreg(REG_A0, (long)BWord);
putreg(REG_D1, 0);
do {
	__emit(0xE4D8);	/* ROXR.W (A0)+ */
	__emit(0xE351);	/* ROXL.W #1,D1 */
}
while (--d > 0);
 
pix = getreg(REG_D1);

I've used your code in this way:

D1 = (D1 << 1) | ((*BWord) & 1);
(*BWord) >>= 1;
(*BWord)++;

Is this right? That instruction seems to have a post increment.
And also. Is this correct to use the code in that way? (also for the original post)

D1 = 0;
do {
*bw = *(UWORD *)((UBYTE *)*plane-- + offset) >> shift;
D1 = (D1 << 1) | ((*bw) & 1);
(*bw) >>= 1;
++bw;
}
while (--d > 0);

Wed, 2012-05-02 17:10

(Reply to #3) #4

thomas

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-16 14:23

You still have difficulties

You still have difficulties understanding the difference between BWord and *BWord, haven't you?

Firstly, the original code moves BWord into A0 and then modifies A0 in a loop but it never moves the modified A0 back to BWord. This means you should not modify BWord in your code.

And secondly (A0)+ means that it accesses the address to which A0 points and then increments A0. The increment should be translated into A0++ and not into (*A0)++ like you do.

Wed, 2012-05-02 17:25

(Reply to #4) #5

afxgroup

Offline

Last seen: 5 months 2 weeks ago

Joined: 2011-02-03 15:26

damned copy & paste.. i

damned copy & paste.. i didn't spot the missing "*"...
so it will became

    D1 = (D1 << 1) | (BWord & 1);
    BWord >>= 1;
    BWord++;

is this correct? (i didn't test it.. i'm at work..)

but is the increment needed or not? from your words "This means you should not modify BWord in your code." i understand that i shouldn't touch it. But if so.. when the increment is done?

Wed, 2012-05-02 23:18

(Reply to #5) #6

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

This code: d =

This code:

d = FloodDepth;
putreg(REG_A0, (long)BWord);
putreg(REG_D1, 0);
do {
    __emit(0xE4D8);	/* ROXR.W (A0)+ */
    __emit(0xE351);	/* ROXL.W #1,D1 */
}
while (--d > 0);
 
pix = getreg(REG_D1);

turned into C should be:

d = FloodDepth;
UWORD *A0 = (UWORD *)BWord;
UWORD D1 = 0;
do {
    D1 = (D1 << 1)|(*A0 & 1);
    *A0 >>= 1; A0++;
} while (--d > 0);
pix = D1;

Sat, 2012-05-05 15:04

(Reply to #6) #7

afxgroup

Offline

Last seen: 5 months 2 weeks ago

Joined: 2011-02-03 15:26

all seems working correctly..

all seems working correctly.. but i think there is this function that is needed even if i've used the ReadPixel from gfx library.. but it seems not correct:

static UWORD ReadPixelFunc[] =
{
	0x48E7,0x3000, //	movem.l	d2-d3,-(sp)
	0x3429,0x0000, //	move.w	bm_BytesPerRow(a1),d2
	0xC2C2,		   //	mulu		d2,d1			; offset (d1) = bytesperrow * y
	0x2400,		   //	move.l	d0,d2
	0xE682,		   //	asr.l		#3,d2
	0xD282,		   //	add.l		d2,d1	 		; offset += x >> 3
	0x0240,0x0007, //	andi.w	#7,d0
	0x7407,		   //	moveq		#7,d2
	0x9440,		   //	sub.w		d0,d2			; bit (d2) = 7 - (x & 7)
	0x48C2,		   //	ext.l		d2
	0x7600,		   //	moveq		#0,d3
	0x1629,0x0005, //	move.b	bm_Depth(a1),d3
	0x5343,		   //	subq		#1,d3			; plane (d3) = depth - 1
	0x2003,		   //	move.l	d3,d0
	0xE580,		   //	asl.l		#2,d0
	0x5080,		   //	addq.l	#bm_Planes,d0
	0xD3C0,		   //	adda.l	d0,a1			; planes (a1) = &bmap->Planes[plane]
	0x7000,		   //	moveq		#0,d0			; color (d0) = 0
	0x2051,// pxloop: movea.l	(a1),a0
	0xD1C1,		   //	adda.l	d1,a0
	0x0510,		   //	btst.b	d2,(a0)
	0x6702,		   //	beq.b		notset
	0x07C0,		   //	bset.l	d3,d0
	0x5949,// notset:	subq		#4,a1
	0x51CB,0xFFF2, //	dbra		d3,pxloop
	0x4CDF,0x000C, //	movem.l	(sp)+,d2-d3
	0x4E75			//	rts
};
static UBYTE __asm (*ReadPix)(register __a1 struct BitMap *, register __d0 SHORT, register __d1 SHORT)
			  = (UBYTE __asm (*)(register __a1 struct BitMap *, register __d0 SHORT, register __d1 SHORT))ReadPixelFunc;

my ReadPix is:

UBYTE ReadPix(struct BitMap *bmap, SHORT x, SHORT y)
{
	struct RastPort tmpras;
	UBYTE retval;
	InitRastPort(&tmpras);
	tmpras.BitMap = bmap;
	retval = ReadPixel(&tmpras, x, y);
	printf("ReadPix (%ld)\n",retval);
	return retval;
}

But the pixel read from the program seems wrong..

Sat, 2012-05-05 17:46

(Reply to #7) #8

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

Since the assembler code is

Since the assembler code is done as a data array a very simple, although not so efficient solution would be to just call the m68k emulator on it like so:

UBYTE ReadPix(struct BitMap *bmap, SHORT x, SHORT y) {
    return EmulateTags(ReadPixelFunc,
        ET_RegisterA1, bmap,
        ET_RegisterD0, x,
        ET_RegisterD1, y,
        TAG_END);
}

Sat, 2012-05-05 17:52

(Reply to #8) #9

afxgroup

Offline

Last seen: 5 months 2 weeks ago

Joined: 2011-02-03 15:26

uh.. just tried.. i get a DSI

uh.. just tried.. i get a DSI when the function is called. And the stack trace points to 68k code.

Sat, 2012-05-05 18:15

(Reply to #9) #10

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

Well from a quick look at the

Well from a quick look at the assembler code this should be a suitable C replacement:

UBYTE ReadPix(struct BitMap *bmap, SHORT x, SHORT y) {
	ULONG byte = (y * bmap->BytesPerRow) + (x >> 3);
	ULONG bit = 7 - (x & 7);
	ULONG i, res = 0;
	UBYTE *plane;
	for (i = 0; i < bmap->Depth; i++) {
		plane = (UBYTE *)bmap->Planes[i];
		if ((plane[byte] >> bit) & 1) {
			res |= (1 << i);
		}
	}
	return res;
}

It's not identical in that the assembler code handles the bitplanes in the opposite order but the end result should be the same.

Sat, 2012-05-05 18:17

(Reply to #10) #11

afxgroup

Offline

Last seen: 5 months 2 weeks ago

Joined: 2011-02-03 15:26

ok mate.. line 9 was: res |=

ok mate.. line 9 was: res |= (1 << *plane) but it works.. like the other soultion (EmulateTags). I've found the problem of the DSI...my error..
So now i'm 100% sure that ReadPix function works because i can see the color under mouse position and is the correct one..
So the problem is for sure in that other file. And so in the that two functions. Your function seems to work correctly but this one:

putreg(REG_D1, 0);
    do {
    *bw = *(UWORD *)((UBYTE *)*plane-- + offset) >> shift;
    putreg(REG_A0, (long)bw);
    __emit(0xE4D0);	/* ROXR.W (A0) */
    __emit(0xE351);	/* ROXL.W #1,D1 */
    ++bw;
    }
    while (--d > 0);

seems always wrong..

Sat, 2012-05-05 18:27

(Reply to #11) #12

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

@afxgroup That line 9 should

@afxgroup

That line 9 should have been "res |= (1 << i);". I've fixed it in the post above. While working on the code I changed around the names of the variables and simply forgot to change it in this one line.

Just a thought, where does the bitmap come from that is passed to ReadPix()? The function as it is now will only work with a planar bitmap and will DSI and return completely wrong results if passed a chunky bitmap.

Sat, 2012-05-05 18:35

(Reply to #12) #13

salass00

Offline

Last seen: 6 months 1 week ago

Joined: 2011-02-03 11:27

100% C version of this

100% C version of this code:

putreg(REG_D1, 0);
do {
    *bw = *(UWORD *)((UBYTE *)*plane-- + offset) >> shift;
    putreg(REG_A0, (long)bw);
    __emit(0xE4D0);	/* ROXR.W (A0) */
    __emit(0xE351);	/* ROXL.W #1,D1 */
    ++bw;
}
while (--d > 0);

should be:

ULONG D1 = 0;
UWORD *A0;
do {
    *bw = *(UWORD *)((UBYTE *)*plane-- + offset) >> shift;
    A0 = (UWORD *)bw;
    D1 = (D1 << 1)|(*A0 & 1)
    *A0 >>= 1;
    ++bw;
} while (--d > 0);

Sat, 2012-05-05 19:40

(Reply to #13) #14

afxgroup

Offline

Last seen: 5 months 2 weeks ago

Joined: 2011-02-03 15:26

Yes the funcion is called

Yes the funcion is called only when there is a planar bitmap.

Search form

User login