Building a NewMenu with localized texts gives me errors

5 posts / 0 new

Last post

Sun, 2021-11-28 00:55

walkero

Offline

Last seen: 4 months 3 days ago

Joined: 2009-05-03 16:54

Building a NewMenu with localized texts gives me errors

Hello guys,
I am pretty confused while I try to build a new menu for iGame. The reason I am doing it is that on AROS 68K there is a problem with the old menu and doesn't show up at all.

To compile iGame for 68K I am using NDK39 and MUI 3.8 SDK. So, started build the new menu like below

static struct NewMenu MenuMainWin[] =
{
	{ NM_TITLE, "Actions"										, 0 ,0 ,0							,(APTR)MEN_ACTIONS },
	{ NM_ITEM ,  "Scan repositories..."			,"R",0 ,0							,(APTR)MEN_SCAN },
	{ NM_ITEM ,  "Add game..."							,"A",0 ,0							,(APTR)MEN_ADDGAME },
	{ NM_ITEM ,  NM_BARLABEL								, 0 ,0 ,0							,(APTR)0 },
	{ NM_ITEM ,  "About..."									,"?",0 ,0							,(APTR)MEN_ABOUT },
	{ NM_ITEM ,  NM_BARLABEL								, 0 ,0 ,0							,(APTR)0 },
	{ NM_ITEM ,  "Quit"											,"Q",0 ,0							,(APTR)MEN_QUIT },
 
	{ NM_END,NULL,0,0,0,NULL }
};

The above works fine and the menu shows up on AROS 68K, along with other OSes. But when I try to replace a label with something like

GetMBString(MSG_MNlabel2Actions)

but I get an error like

error 46: initializer not a constant

Below is the GetMBString() which returns a const unsigned char *

const unsigned char* GetMBString(const unsigned char* ref)
{
	if (ref[1] == '\0')
		return &ref[2];
	return ref;
}

Below you can see how the MSG_MNlabel2Actions is defined in code that is generated by flexcat, using the .cd file.

extern struct FC_String iGame_Strings[104];
 
#define MSG_MNlabel2Actions (iGame_Strings[3].msg)
#define _MSG_MNlabel2Actions (iGame_Strings+3)

Below is how the iGame_Strings struct is configured.

struct FC_String iGame_Strings[104] = {
    { (STRPTR) "A front-end to WHDLoad", 0 },
    { (STRPTR) "Emmanuel Vasilakis", 1 },
    { (STRPTR) "iGame", 2 },
    { (STRPTR) "Actions", 3 }
};

I also changed the whole locale file to use CatComp exported strings and GetCatalogStr(), but the error is again the same.

Can you please help me on solving this one, because it drives me crazy a few days now. What am I doing wrong?

Sun, 2021-11-28 11:57

jabirulo

Offline

Last seen: 1 month 7 hours ago

Joined: 2013-05-30 00:53

Re: Building a NewMenu with localized texts gives me errors

Hi, in Mixer this is how NewMenu is build (menus.c):

...
#define CATCOMP_NUMBERS
#define CATCOMP_BLOCK
#define CATCOMP_CODE
#include "mixer_strings.h"
extern struct LocaleInfo li;
 
#define STR_ID(x) ( (STRPTR)(x) )
#define MENU_ID(x) ( (APTR)(x) )
 
struct NewMenu MenuStripDescriptors[] = {                                   // MUST match # in menus.h
 { NM_TITLE, STR_ID(-1),                   0 , 0, 0, MENU_ID(0)          }, // 0 = PROJECT menutitle
 {  NM_ITEM, STR_ID(MSG_PROJECT_LOAD),    "O", 0, 0, MENU_ID(MID_LOAD)   }, // 1
 {  NM_ITEM, STR_ID(MSG_PROJECT_SAVE),    "S", 0, 0, MENU_ID(MID_SAVE)   }, // 2
 {  NM_ITEM, STR_ID(MSG_PROJECT_MODIFY),   0 , 0, 0, MENU_ID(MID_MODIFY) }, // 3 
 {  NM_ITEM, STR_ID(MSG_PROJECT_HIDE),    "H", 0, 0, MENU_ID(MID_HIDE)   }, // 4
 {  NM_ITEM, STR_ID(MSG_PROJECT_ICONIFY), "I", 0, 0, MENU_ID(MID_ICONIFY)}, // 5
 {  NM_ITEM, NM_BARLABEL,                  0 , 0, 0, MENU_ID(0)          }, // 6
 {  NM_ITEM, STR_ID(MSG_PROJECT_ABOUT),   "?", 0, 0, MENU_ID(MID_ABOUT)  }, // 7
 {  NM_ITEM, NM_BARLABEL,                  0 , 0, 0, MENU_ID(0)          }, // 8
 {  NM_ITEM, STR_ID(MSG_PROJECT_QUIT),    "Q", 0, 0, MENU_ID(MID_QUIT)   }, // 9
 { NM_TITLE, STR_ID(-1),                   0 , 0, 0, MENU_ID(0)            }, // 10 = EDIT menutitle
 {  NM_ITEM, STR_ID(MSG_EDIT_DEFAULTS),   "D", 0, 0, MENU_ID(MID_DEFAULTS) }, // 11
 {  NM_ITEM, STR_ID(MSG_EDIT_LASTSAVED),  "L", 0, 0, MENU_ID(MID_LASTSAVED)}, // 12
 {  NM_ITEM, STR_ID(MSG_EDIT_RESTORE),    "R", 0, 0, MENU_ID(MID_RESTORE)  }, // 13
 
 {  NM_END,  STR_ID(-1),                   0 , 0, 0, MENU_ID(0)}
};
...

later on main it uses this to use translations (main.c):

...
#include <proto/locale.h>
#define CATCOMP_NUMBERS
#define CATCOMP_BLOCK
//#define CATCOMP_CODE
#include "include/mixer_strings.h"
struct Library *LocaleBase = NULL;
struct LocaleIFace *ILocale = NULL;
struct LocaleInfo li;
...
TranslateMenus(&li, MenuStripDescriptors);
...
void TranslateMenus(struct LocaleInfo *li, struct NewMenu *nm)
{
 while(nm->nm_Type != NM_END)
 {
  if(nm->nm_Label != NM_BARLABEL)
   nm->nm_Label = (STRPTR)GetString(li, (int32)nm->nm_Label);
 
  nm++;
 }
}

and catalog sources are build like this:
CatComp mixer.cd CFILE include/mixer_strings.h

If your program is gouing to be only AOS4.1'aware, it could be easier to use "menuclass":

...
    akdt->OBJ(OID_MENUS) = NewObject(NULL, "menuclass",
 
     MA_AddChild, NewObject(NULL, "menuclass",
      MA_Type,T_MENU, MA_Label,GETMSG(MSG_AKDT_MENU_PROJECT),
      MA_AddChild, NewObject(NULL, "menuclass",
        MA_Type,T_ITEM, MA_Label,GETMSG(MSG_AKDT_MENU_PROJECT_OPEN),
        MA_ID,    AKDT_MENU_PROJECT_OPEN,
        MA_Key,   "O",
        MA_Image, MenuImage("open",akdt->akdt_Screen),
      TAG_END),
      MA_AddChild, NewObject(NULL, "menuclass",
        MA_Type,T_ITEM, MA_Label,GETMSG(MSG_AKDT_MENU_PROJECT_SAVEAS),
        MA_ID,    AKDT_MENU_PROJECT_SAVEAS,
        MA_Key,   "A",
        MA_Image, MenuImage("saveas",akdt->akdt_Screen),
      TAG_END),
...

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Sun, 2021-11-28 12:02

jabirulo

Offline

Last seen: 1 month 7 hours ago

Joined: 2013-05-30 00:53

Re: Building a NewMenu with localized texts gives me errors

Not sure but the problem you get is 'cos your are declaring "struct NewMenu MenuMainWin[] =" and you try to add "inside" a function, that's not possible. Don't know how to explain it better/clearer.

As you can see in example above (mixer menus.c and main.c), it declares a struct with "fixed" values (builtin strings) and later they are "replaced" with translations.

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Mon, 2021-11-29 00:56

walkero

Offline

Last seen: 4 months 3 days ago

Joined: 2009-05-03 16:54

Re: Building a NewMenu with localized texts gives me errors

@jabirulo
Thank you so much for your help and explanation, and for pointing me in the right direction. I got it working.

It would be so nice if this was possible to work just by giving a simple char * there.

And the Reaction MenuClass is also a very good way to create menus. That's what I am using on my ReAction based apps, but the one I am currently updating is based on MUI.

Thanks again for your help.

Thu, 2021-12-02 08:00

(Reply to #4) #5

hypex

Offline

Last seen: 4 months 2 days ago

Joined: 2011-09-09 16:20

Re: Building a NewMenu with localized texts gives me errors

Could it be because you declared the menu as static? With const data this will fine. But if you need to call a function then that become dynamic at run time. I think one way around it would be to declare the menu as non static. I can see how static is useful in place. But if you need to build it at run time it's not static any more. Perhaps build it once and reference as a pointer?

Search form

User login