Using Tags for our own functions

14 posts / 0 new

Last post

Sat, 2016-01-23 15:06

YesCop

Offline

Last seen: 4 years 3 months ago

Joined: 2011-05-17 15:07

Using Tags for our own functions

Hello,
I am testing the TagItem structure in my function
Here is some parts of the code inspired by the AmigaOSWiki.

void Test(uint32 n, ...) {
 
uint item = 1;
struct TagItem *tags = (struct TagItem *) &n; // Here may be the problem. How does gcc read the stack? 
struct TagItem *ctags=IUtility->CloneTagItems (tags); //not useful, just for testing the function, at least I think.
struct TagItem *ltags=ctags;
struct TagItem *tag;
 
	while (tag = IUtility->NextTagItem (&ltags)) {
 
   		uint32 titag   = tag->ti_Tag;
   		uint32 tidata = tag->ti_Data;
   		cout <<"Element "<<item<<": First="<<titag<<", Second="<<tidata<<endl;
		++item;
    	}
    		IUtility->FreeTagItems (ctags);
}
 
int main(int argc, char *argv[]) {
 
Test(1,4,2,46,3,31,4,65,5,86, TAG_END);
 
return 0;
 
<cpp-qt>
 
Here the output :
Element 1: First=1297767648, Second=1866413944
Element 2: First=1297767680, Second=1866413840
Element 3: First=5, Second=86
 
As you can read, I only obtain 5 and 86. I think that it prints the address and not the values but I don't know why.
I would want to undersand better how the methods and TagItem work.
I mean, how the parameters of Test() are converted into TagItem and vice-versa when they are not only int but float, pointers, strings...?
 
The purpose of all this is of course to use Test() with a variety of parameters.
 
Thanks for reading.

Sat, 2016-01-23 15:32

thomas

Offline

Last seen: 3 days 18 hours ago

Joined: 2011-05-16 14:23

Re: Using Tags for our own functions

On a PPC OS you cannot use just &n to get a tag list.

Read section 5.2 of SDK:Documentation/Developer Info/General/Migration Guide.pdf

Sat, 2016-01-23 17:10

LyleHaze

Offline

Last seen: 2 years 1 month ago

Joined: 2011-05-26 03:58

Re: Using Tags for our own functions

Also, the choice of tag values has restrictions, especially if you're using utility tag management functions.
You can read more in
SDK:Include/include_h/utility/tagitem.h

LyleHaze

Sat, 2016-01-23 23:04

(Reply to #3) #4

YesCop

Offline

Last seen: 4 years 3 months ago

Joined: 2011-05-17 15:07

Re: Using Tags for our own functions

Thomas, thanks to remind me of this pdf.
My first version of my test function uses va_list and co. That works well without trick.
I would want the AmigaOS Wiki to verify his code. I though that the source published in this site was 'OS4 proof'.

Lyle, I had already read the include file. I didn't see what you wanted to point to except may be that the TagItem structure contains two ints.
My interest about Tags was the possibility to use as variables int and strings (pointers). I wanted to obtain something like a lot if OS4 functions like OpenwindowTags (Tag1=2, Tag2="My window"...

I am a little disappointed about this.
Thanks for your replies.

Sun, 2016-01-24 00:19

(Reply to #4) #5

thomas

Offline

Last seen: 3 days 18 hours ago

Joined: 2011-05-16 14:23

Re: Using Tags for our own functions

I had already read the include file. I didn't see what you wanted to point to

The values you use for ti_Tag are already used by the system and have special meanings:

1 is TAG_IGNORE
2 is TAG_MORE
3 is TAG_SKIP

Especially TAG_MORE is dangerous if ti_Data does not point to another tag list.

You should always set the TAG_USER bit on your own tags.

Tue, 2016-01-26 03:29

(Reply to #5) #6

YesCop

Offline

Last seen: 4 years 3 months ago

Joined: 2011-05-17 15:07

Re: Using Tags for our own functions

Thanks.
You are right about TAG_USER.
Finally after some tests, I don't really see the interest usings tagitem.h.
I consider simpler using own tags and va_list so I can use whatever types.

If some reader thinks that I am wrong, feel free to give an example.

Tue, 2016-01-26 12:44

(Reply to #6) #7

thomas

Offline

Last seen: 3 days 18 hours ago

Joined: 2011-05-16 14:23

Re: Using Tags for our own functions

If you only use it in your own programs, it is up to you. But if you want to publish the interface, you should use utility.library functions to examine the tag list and thus use linear varargs.

Here is an example which demonstrates the difference:

#include <stdarg.h>
#include <proto/dos.h>
#include <proto/utility.h>
 
 
void func1 (ULONG dummy, ...)
{
va_list args;
ULONG tag,data;
 
va_start (args,dummy);
 
Printf ("\nfunc1: begin of tag list\n");
while ((tag = va_arg(args,ULONG)))
	{
	data = va_arg(args,ULONG);
	Printf ("%-4lu = %lu\n",tag,data);
	}
Printf ("func1: end of tag list\n");
 
va_end (args);
}
 
 
VARARGS68K
void func2 (ULONG dummy, ...)
{
va_list args;
struct TagItem *taglist,*ti;
 
va_startlinear (args,dummy);
 
taglist = va_getlinearva(args,struct TagItem *);
 
Printf ("\nfunc2: begin of tag list\n");
while ((ti = NextTagItem (&taglist)))
	{
	Printf ("%-4lu = %lu\n",ti->ti_Tag,ti->ti_Data);
	}
Printf ("func2: end of tag list\n");
 
va_end (args);
}
 
 
 
int main (void)
 
{
ULONG taglist[] = {1004, 5, TAG_END};
 
func1 (0,
	1001, 2,
	1002, 3,
	1003, 4,
	TAG_END);
 
func2 (0,
	1001, 2,
	1002, 3,
	1003, 4,
	TAG_END);
 
func2 (0,
	1001, 2,
	TAG_IGNORE, 6,
	1002, 3,
	TAG_SKIP, 2,
	1005, 5,
	1006, 6,
	1003, 4,
	TAG_MORE, taglist);
 
return (0);
}

As you can see by the second call to func2, a real tag list can be rather complicated and NextTagItem handles it all.

Sun, 2016-01-31 02:14

(Reply to #7) #8

YesCop

Offline

Last seen: 4 years 3 months ago

Joined: 2011-05-17 15:07

Re: Using Tags for our own functions

Thanks Thomas.
I read and compile your example. I learned something, I didn't know VARARGS68K.
Could you tell me if you know what is the interest to write some tags in the call and ignore them in fact?

Sun, 2016-01-31 03:17

(Reply to #8) #9

thomas

Offline

Last seen: 3 days 18 hours ago

Joined: 2011-05-16 14:23

Re: Using Tags for our own functions

You can programmatically decide whether some tags should be used or not

for example

window = OpenWindowTags (NULL,
	width > 0 ? WA_Width : TAG_IGNORE, width,
	height > 0 ? WA_Height : TAG_IGNORE, height,
	TAG_END);

window = OpenWindowTags (NULL,
	no_size ? TAG_SKIP : TAG_IGNORE, 2,
	WA_Width, width,
	WA_Height, height,
	TAG_END);

TAG_MORE can be used for example to forward a given taglist to a subroutine with some tags added:

subroutine (dummy,
	my_tag1, my_value1,
	my_tag2, my_value2,
	TAG_MORE, given_taglist);

Sun, 2016-01-31 21:13

#10

YesCop

Offline

Last seen: 4 years 3 months ago

Joined: 2011-05-17 15:07

Re: Using Tags for our own functions

Ok.
Thanks for your answers.

Tue, 2016-06-21 00:43

(Reply to #10) #11

YesCop

Offline

Last seen: 4 years 3 months ago

Joined: 2011-05-17 15:07

Re: Using Tags for our own functions

Thomas,
I have one more question. I played with tags and int, strings and floats.
I must convert float to fixpoint in the call and I can use it next converting back.
Is there any way to not convert values in the call to the function?
And I didn't succeed with negative values.

Here is the example to illustrate.
Func1(tag1, "text", tag2, COMP-float-to-fix(2.3), tag3, -1)

I would wish to remove the comp-float from the call and use negative values.

Tue, 2016-06-21 17:28

(Reply to #11) #12

thomas

Offline

Last seen: 3 days 18 hours ago

Joined: 2011-05-16 14:23

Re: Using Tags for our own functions

The problem is that the compiler converts float (32 bits) into double (64 bits) before it pushes them on the stack. But the ti_Data field is only 32 bits wide. So you have to assure that the 32 bit floats are stored (and later read) as-is and not converted.

This trick could work:

float x = 2.3;
Func1(tag1, "text", tag2, *((ULONG *)&x), tag3, -1, TAG_END);

and reading by the opposite:

x = *((float *)&ti->ti_Data);

Thu, 2016-06-23 02:36

(Reply to #12) #13

YesCop

Offline

Last seen: 4 years 3 months ago

Joined: 2011-05-17 15:07

Re: Using Tags for our own functions

Thank for the explanation. I hadn't imagined the 64 bit stack.
Your trick worked.
Thanks.

Sat, 2016-07-09 19:27

(Reply to #13) #14

hypex

Offline

Last seen: 4 months 2 weeks ago

Joined: 2011-09-09 16:20

Re: Using Tags for our own functions

They had this problem when porting OS4 to PPC. The tags weren't designed to be dynamic and support variable sized data. And this presented a problem for 64-bit data like a float. One solution is to simply use a pointer instead. Then you don't have to worry about the size. Just specifying the correct datatype.

Search form

User login