change button image dynamically

23 posts / 0 new

Last post

Mon, 2016-05-02 22:15

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

change button image dynamically

Hi, is ti possible to have a button with an imagen and when I click on antoher object/gadget (listbrowser entry) to change such image in the button?

Alas now everything I tried didn't work, 'cos I'm doing something wrong or missing a step. Or not underdtanding autodocs at all.

#define OBJ(x) Objects[x]
...
PAGE_Add, OBJ(OBJ_GEN) = IIntuition->NewObject(NULL, "layout.gadget",
...
              LAYOUT_AddChild, OBJ( OBJ_PREVIEW_BTN) = IIntuition->NewObject(NULL, "button.gadget",
               GA_ID,         OBJ_PREVIEW_BTN,
               GA_RelVerify,  TRUE,
               GA_Underscore, 0,
               BUTTON_BevelStyle,  BVS_NONE,
               BUTTON_Transparent, TRUE,
               BUTTON_RenderImage, OBJ(OBJ_PREVIEW_IMG) = IIntuition->NewObject(NULL, "bitmap.image",
                IA_Width,  256, IA_Height, 224,
                BITMAP_SourceFile, "IMAGE.PNG",
                BITMAP_Screen,     screen,
               TAG_DONE),
              TAG_DONE),
              CHILD_MaxWidth, 256, // pixels width of preview
              CHILD_WeightedHeight, 0, // align image at top
...
 if( (pwindow = (struct Window *)IIntuition->IDoMethod(OBJ(OBJ_MAIN), WM_OPEN, NULL)) )
...

It shows IMAGE.PNG ok on the button, but how the modify sucg image-button with IMAGE2,.PNG and (re)show it?
One of my try/test is:

...
case WMHI_GADGETUP:
switch(result & WMHI_GADGETMASK)
{
...
 case OBJ_CHANGE_IMG:
  // Remove image-button (but nothing happens) :-(
  if( OBJ(OBJ_PREVIEW_IMG) ) {
   IIntuition->IDoMethod(OBJ(OBJ_GEN), LM_REMOVECHILD, pwindow, OBJ(OBJ_PREVIEW_IMG) );
   OBJ(OBJ_PREVIEW_IMG) = NULL;
  }
 
  OBJ(OBJ_PREVIEW_IMG) = IIntuition->NewObject(NULL, "bitmap.image",
   IA_Width,  256, IA_Height, 224,
   BITMAP_SourceFile, "IMAGE2.PNG",
   BITMAP_Screen,     screen,
  TAG_DONE);
 
  IIntuition->IDoMethod(OBJ(OBJ_PREVIEW_BTN), LM_ADDCHILD, pwindow, OBJ(OBJ_PREVIEW_IMG), NULL);
  IIntuition->IDoMethod(OBJ(OBJ_MAIN), WM_RETHINK);
break;
}
...

Thanks In Advance

Tue, 2016-05-03 00:14

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

Answering mysefl, maybe is still not very "pro", but seems to work this:

  if( OBJ(OBJ_PREVIEW_BTN) ) {
   IIntuition->IDoMethod( OBJ(OBJ_PREVIEW), LM_REMOVECHILD, pw, OBJ(OBJ_PREVIEW_BTN) );
   OBJ(OBJ_PREVIEW_BTN) = NULL;
  }
 
  OBJ(OBJ_PREVIEW_BTN) = IIntuition->NewObject(NULL, "button.gadget",
   GA_ID,         OBJ_PREVIEW_BTN,
   GA_RelVerify,  TRUE,
   GA_Underscore, 0,
   BUTTON_BevelStyle,  BVS_NONE,
   BUTTON_Transparent, TRUE,
   //BUTTON_BackgroundPen, BLOCKPEN,
   //BUTTON_FillPen,       BLOCKPEN,
   BUTTON_RenderImage, OBJ(OBJ_PREVIEW_IMG) = IIntuition->NewObject(NULL, "bitmap.image",
   IA_Width,  256,
   IA_Height, 224,
   BITMAP_SourceFile, resul,
   BITMAP_Screen,     screen,
   TAG_DONE),
  TAG_DONE);
  IIntuition->IDoMethod(OBJ(OBJ_PREVIEW), LM_ADDCHILD, pw, OBJ(OBJ_PREVIEW_BTN), NULL);
  IIntuition->IDoMethod(OBJ(OBJ_MAIN), WM_RETHINK);
 }

being:

            // GENERAL page
            PAGE_Add, OBJ(OBJ_GEN) = IIntuition->NewObject(NULL, "layout.gadget",
             LAYOUT_Orientation, LAYOUT_ORIENT_VERT,
             LAYOUT_SpaceOuter,  TRUE,
             LAYOUT_SpaceInner,  TRUE,
             LAYOUT_AddChild, OBJ(OBJ_PREVIEW) = IIntuition->NewObject(NULL, "layout.gadget",
              //LAYOUT_Orientation, LAYOUT_ORIENT_VERT,
              LAYOUT_SpaceOuter,  TRUE,
              LAYOUT_BevelStyle,  BVS_GROUP,
              LAYOUT_Label,       "Game / Preview",
 ...
              LAYOUT_AddChild, OBJ(OBJ_PREVIEW_BTN) = IIntuition->NewObject(NULL, "button.gadget",
               GA_ID,         OBJ_PREVIEW_BTN,
               GA_RelVerify,  TRUE,
               GA_Underscore, 0,
...

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Tue, 2016-05-03 00:27

(Reply to #2) #3

TSK

Offline

Last seen: 1 year 1 month ago

Joined: 2011-06-28 02:06

Re: change button image dynamically

IIntuition->SetGadgetAttrs((struct Gadget *)OBJ(OBJ_PREVIEW_BTN),window,NULL,BUTTON_RenderImage,NULL,TAG_DONE);
IIntuition->DisposeObject(OBJ(OBJ_PREVIEW_IMG));
OBJ(OBJ_PREVIEW_IMG)=IIntuition->NewObject(.....);
IIntuition->SetGadgetAttrs((struct Gadget *)OBJ(OBJ_PREVIEW_BTN),window,NULL,BUTTON_RenderImage,OBJ(OBJ_PREVIEW_IMG),TAG_DONE);

Or if it's on a clicktab page then use ILayout->SetPageGadgetAttrs(); instead of SetGadgetAttrs();

ILayout->SetPageGadgetAttrs((struct Gadget *)OBJ(OBJ_PREVIEW_BTN),OBJ(OBJ_GEN),window,NULL,BUTTON_RenderImage,OBJ(OBJ_PREVIEW_IMG),TAG_DONE);

Tue, 2016-05-03 01:36

(Reply to #3) #4

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

THX will test it ASAP (aka tomorrow). :-)

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Tue, 2016-05-03 14:32

(Reply to #4) #5

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

Tried and working PERFECT!!!! THX MAN :-)

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Tue, 2016-05-03 16:13

(Reply to #5) #6

broadblues

Offline

Last seen: 4 years 9 months ago

Joined: 2012-05-02 21:48

Re: change button image dynamically

A little background info on what is going on here:

You can change the image at any time by setting the BUTTON_RenderImage attribute to a new value via the OM_SET method which for all practical purposes is most usually called vai the SetAttrs() family of calls.

SetAttrs() itself only sets the new value for the attribute, in order to have it display you need to pass some information to the gadget to enable it to render. For this you need to use SetGadgetAttrs() this populates the GadgetInfo structure in the struct opSet message passed to gadget.

In the case of changing the button image it will autmatically rerender, some chnages don't for example setting disabled doesn't in that case you need to use either RefreshSetGadgetAttrs() or a seperate calle to RefreshGList()

As TSK mentioned there are some special versions of SetAttrs for gadgets like the PageGadget (most often used with click tabs) and also the virtual gadget.

Wed, 2016-05-04 18:25

(Reply to #6) #7

hypex

Offline

Last seen: 3 months 3 weeks ago

Joined: 2011-09-09 16:20

Re: change button image dynamically

Also it is recommended to cache the class pointers. So using IIntuition->OpenClass() to open what classes you need and pass the class pointer to NewObject(). So you save the OS looking up the class name for every GUI object you add.

I'd also apply this to your images and cache these. So that when your gadget images change you program doesn't reload another image off disk every time.

Fri, 2016-05-06 10:14

(Reply to #7) #8

trixie

Offline

Last seen: 6 months 3 weeks ago

Joined: 2011-02-03 13:58

Re: change button image dynamically

Also it is recommended to cache the class pointers. So using IIntuition->OpenClass() to open what classes you need and pass the class pointer to NewObject(). So you save the OS looking up the class name for every GUI object you add.

I second that recommendation. Using a global class pointer in NewObject(), rather than the public class name, can optimize GUI creation times. Especially with more complex GUIs and on lower-end systems (like my Sam440) the speedup is noticeable.

AmigaOne X5000-020 / 2GB RAM / Sapphire Pulse Radeon RX 560 / AmigaOS 4.1 Final Edition Update 2

Fri, 2016-05-06 12:41

(Reply to #8) #9

thomas

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-16 14:23

Re: change button image dynamically

One other hint: if you do not OpenClass() then NewObject() with name might fail if the class you want to use has not yet been opened by another program or flushed from memory by a low-memory condition. NewObject() only searches in memory, it does not load classes from disk.

And if you do OpenClass(), you get a class pointer anyway, so you can as well use it.

Fri, 2016-05-06 19:03

(Reply to #9) #10

hypex

Offline

Last seen: 3 months 3 weeks ago

Joined: 2011-09-09 16:20

Re: change button image dynamically

I second that recommendation

Yes I actually looked up your guide trixie. I knew you wrote one. A few years now but looks to still be current. I forgot to put the link so for those interested:

http://www.os4coding.net/blog/trixie/recommended-practice-os4-reaction-programming

Mon, 2016-05-09 14:36

(Reply to #10) #11

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

thx, I do use Classpointer, but I go step by step :-)
When you mean "cache images" do you mean I "preload" and store such images in a bitmap or object variable (or using Alloc.../Free..).
?

TIA

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Mon, 2016-05-09 19:14

(Reply to #11) #12

thomas

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-16 14:23

Re: change button image dynamically

When you mean "cache images" do you mean I "preload" and store such images in a bitmap or object variable (or using Alloc.../Free..).
?

If you look at TSK's suggestion, he

- detaches the old image from the button
- frees the old image
- loads the new image (which might fail!)
- attaches the new image to the button

There is a lot of unnecessary I/O involved as well as the possible failure and also the button might flicker if you use SetGadgetAttrs in both cases.

The better way is to load all images in the beginning of your program and keep them alive until your program finishes. Then you can change the button imagery by just one call to SetGadgetAttrs.

Tue, 2016-05-10 00:57

(Reply to #12) #13

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

Ok, but I have 1000 images/previews, is a list with ROM files. Si IMO this time is "ok" to this way. And previously I check if image/file exists:

...
 // Check if filename exists
  struct ExamineData *dat = IDOS->ExamineObjectTags(EX_StringNameInput,filename, TAG_END);
  if(dat == NULL)
  {
   IUtility->Strlcpy(filename, ROMS"/Previews/availablepreview.png", 1024);
   dat = IDOS->ExamineObjectTags(EX_StringNameInput,filename, TAG_END);
  }
  if(dat)
  {
   IDOS->FreeDosObject(DOS_EXAMINEDATA, dat);
 
   // "Unbind" preview, remove it, create new, and add/show new image to window/pagetab
...

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Wed, 2016-05-11 15:20

(Reply to #13) #14

thomas

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-16 14:23

Re: change button image dynamically

Ok, then loading all images in the beginning is not an option.

But anyway I would use this sequence:

new_img = NewObject(....);
SetGadgetAttrs (preview_button, window, NULL, BUTTON_RenderImage, new_img, TAG_END);
DisposeObject (preview_img);
preview_img = new_img;

Sat, 2016-05-21 19:14

(Reply to #14) #15

hypex

Offline

Last seen: 3 months 3 weeks ago

Joined: 2011-09-09 16:20

Re: change button image dynamically

When you mean "cache images" do you mean I "preload" and store such images in a bitmap

Yes that's what I meant. For any common images. To preload them into a bitmap object.

But your 1,000 images sounds like a lot, is it some type of image requester? Are they all displayed at once? In that case preload what can be seen on screen.

You said ROM images so I wonder if they are names with an image associated with type. But I don't know. Got an image of it? ;-)

Fri, 2016-06-10 15:48

#16

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

Hi, just having sometimes after uniconifying and click on another listbrowser enrty a system freeze that points here (part of changing image on button), but dunnot what I'm doing wrong.

Shoudl I dispose the button image on iconifying?

...
  {
   Object *newobj = NULL;
   IDOS->FreeDosObject(DOS_EXAMINEDATA, dat);
   if( (newobj=IIntuition->NewObject(BitMapClass, NULL, //"bitmap.image",
                                     IA_Scalable,TRUE, BITMAP_Screen,screen,
                                     BITMAP_SourceFile,filename, TAG_DONE)) )
   {
    IIntuition->SetGadgetAttrs(GAD(OID_PREVIEW_BTN), pw, NULL, BUTTON_RenderImage,newobj, GA_Text,"", TAG_DONE);
    IIntuition->DisposeObject( OBJ(OID_PREVIEW_IMG) );
    OBJ(OID_PREVIEW_IMG) = newobj;
    ILayout->SetPageGadgetAttrs(GAD(OID_PREVIEW_BTN), OBJ(OID_GENERAL), pw, NULL, BUTTON_RenderImage,OBJ(OID_PREVIEW_IMG), TAG_DONE); // pagetab
    }
  }
...<code>

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Fri, 2016-06-10 16:38

(Reply to #16) #17

thomas

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-16 14:23

Re: change button image dynamically

I don't know why it crashes. Be aware that the window pointer (pw) and the screen pointer (screen) are different after uniconify and have to be reobtained.

Anyway, another thing which is wrong in your code is the call to SetGadgetAttrs. You must not use SetGadgetAttrs if the gadget is contained in a page. Obviously you are setting the same attribute twice, therefore you should replace SetGadgetAttrs by SetPageGadgetAttrs and remove the second call to SetPageGadgetAttrs alltogether.

Sat, 2016-06-11 00:56

(Reply to #17) #18

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

THX.
'pw' is passed as argument to that function and 'screen' is global (will look if both get properly updated).
Will change to use SetPageGadgetAttrs and dos ome test.
THX again.

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Sat, 2016-06-11 11:42

#19

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

I have in a page/tab a listbrowser with roms game list and on the right a button with the image of rom game entry selected.

Can I make/code it this way to update the image button?:

...
   if( (newobj=IIntuition->NewObject(BitMapClass, NULL, //"bitmap.image",
                                     IA_Scalable,TRUE, BITMAP_Screen,screen,
                                     BITMAP_SourceFile,filename, TAG_DONE)) )
   {
    //ILayout->SetPageGadgetAttrs(GAD(OID_PREVIEW_BTN), OBJ(OID_GENERAL), pw, NULL, GA_Text,"", BUTTON_RenderImage,newobj, TAG_DONE); // "clear" gadgets
    IIntuition->SetAttrs(OBJ(OID_PREVIEW_BTN), GA_Text,"", BUTTON_RenderImage,newobj, TAG_DONE); // "update"
    IIntuition->DisposeObject( OBJ(OID_PREVIEW_IMG) );
    OBJ(OID_PREVIEW_IMG) = newobj;
    //ILayout->SetPageGadgetAttrs(GAD(OID_PREVIEW_BTN), OBJ(OID_GENERAL), pw, NULL, BUTTON_RenderImage,OBJ(OID_PREVIEW_IMG), TAG_DONE); // pagetab
    IIntuition->RefreshSetGadgetAttrs(GAD(OID_PREVIEW_BTN), pw, NULL, BUTTON_RenderImage,OBJ(OID_PREVIEW_IMG), TAG_DONE);
    }
  }
...

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Mon, 2016-06-13 12:51

(Reply to #19) #20

thomas

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-16 14:23

Re: change button image dynamically

Well, you are still in a page, so RefreshSetGadgetAttrs is a no-go, too.

Please keep in mind that all functions of intuition.library assume that the gadgets they work on are visible in the window. If you call SetGadgetAttrs, RefreshGadgets, RefreshGList, RefreshSetGadgetAttrs and so on, these funtions will immediately redraw the gadget into the window.

But gadgets which are part of a page might be hidden. Now if you call one of the intuition.library functions, they will draw the gadget into the window, no matter if it was visible before or not and no matter if it fits into the currently visible page or not.

You should never call intuition.library's gadget functions for gadgets which are part of a page. Only use the functions of page.gadget for these gadgets.

Regarding the sequence of your function calls, you still unnecessarily set the value of BUTTON_RenderImage twice. You use a different variable name, but the value is the same in both cases. Instead of the RefreshSetGadgetAttrs you could use RefreshPageGadget. Attributes don't need to be changed and it is the right function for refresh a gadget contained in a page.

Sun, 2016-06-19 19:29

(Reply to #20) #21

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

okidoki. Now I use:

...
{
    OBJ(OID_PREVIEW_IMG) = newobj;
    ILayout->SetPageGadgetAttrs(GAD(OID_PREVIEW_BTN), OBJ(OID_GENERAL), pw, NULL, BUTTON_RenderImage,OBJ(OID_PREVIEW_IMG), TAG_DONE); // pagetab
    ILayout->RefreshPageGadget(GAD(OID_PREVIEW_BTN), OBJ(OID_GENERAL), pw, NULL);
}
...

BTW I'm not sure if before i should use 'IIntuition->DisposeObject( OBJ(OID_PREVIEW_IMG) )'?

An to refresh a whole page? I'm checking first in what tab/page am and perform 'IIntuition->RefreshGadgets()'

...
IIntuition->GetAttr(CLICKTAB_Current, OBJ(OID_PAGE), &res_value);
DefaultSettings(); // load default snes9x settings
SetGUIGadgets();   // set in GUI snes9x settings
// Refresh settings gadgets
IIntuition->RefreshGadgets(GAD(OID_SETTINGS_GLOBAL), pwindow, NULL); // this one is "outside" tabs/pages
if(res_value == OID_SETTINGS) IIntuition->RefreshGadgets(GAD(OID_SETTINGS), pwindow, NULL);
if(res_value == OID_AMIGAINPUT) IIntuition->RefreshGadgets(GAD(OID_AMIGAINPUT), pwindow, NULL);
...

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Thu, 2016-06-23 18:06

(Reply to #21) #22

thomas

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-16 14:23

Re: change button image dynamically

BTW I'm not sure if before i should use 'IIntuition->DisposeObject( OBJ(OID_PREVIEW_IMG) )'?

You've got a memory leak of you don't. But be sure to use the right pointer in DisposeObject. You must not dispose the old object while it is still connected to the gadget. And of course you don't want to dispose the image you allocated just before.

SetPageGadgetAttrs(page,button,new_img);
Dispose (old_img);

That's the right sequence.

An to refresh a whole page? I'm checking first in what tab/page am and perform 'IIntuition->RefreshGadgets()'

Isn't it sufficient to refresh the page gadget? I would expect it to refresh all its contents.

I would not use RefreshGadgets in a ReAction environment. RefreshGadgets starts at the given gadget and refreshes all gadgets which are linked together by the NextGadget pointer. But in a hierarchical layout structure you never know what the NextGadget field is used for. Therefore I would always use RefreshGList with a counter of 1.

Sat, 2016-06-25 12:19

(Reply to #22) #23

jabirulo

Offline

Last seen: 3 weeks 15 hours ago

Joined: 2013-05-30 00:53

Re: change button image dynamically

About Dispose(): ok, that's what I was thinking of. THX for clarifying.

About refresh whole page: but if I click on 'initial settings' All (most of them) gadgets from Settings (or AmigaInput) page should be refreshed:

...
case OID_LOAD:
 IIntuition->GetAttr(CLICKTAB_Current, OBJ(OID_PAGE), &res_value);
 DefaultSettings(); // load default snes9x settings
 SetGUIGadgets();   // set in GUI snes9x settings
 // Refresh settings gadgets
 IIntuition->RefreshGadgets(GAD(OID_SETTINGS_GLOBAL), pwindow, NULL); // are "outside" pages/tabs
 if(res_value == OID_SETTINGS) IIntuition->RefreshGadgets(GAD(OID_SETTINGS), pwindow, NULL);
 if(res_value == OID_AMIGAINPUT) IIntuition->RefreshGadgets(GAD(OID_AMIGAINPUT), pwindow, NULL);
 break;
...

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Search form

User login