Create buttons in a for(...) loop

19 posts / 0 new

Last post

Mon, 2015-01-12 06:05

mritter0

Offline

Last seen: 2 years 7 months ago

Joined: 2014-04-21 21:15

Create buttons in a for(...) loop

How would I go about changing the below code to have each button be made in a loop with custom details (text, id, etc)?

	if (!(Objects[GAD_BUTTONS_GROUP]=HGroupObject,
		LAYOUT_SpaceOuter,			TRUE,
		LAYOUT_SpaceInner,			TRUE,
		LAYOUT_AddChild,			Objects[GAD_BUTTON1]=NewObject(ButtonClass,NULL,
			GA_ID,						GAD_BUTTON1,
			GA_RelVerify,				TRUE,
			GA_Text,					"Button 1",
		TAG_END),
		LAYOUT_AddChild,			Objects[GAD_BUTTON2]=NewObject(ButtonClass,NULL,
			GA_ID,						GAD_BUTTON2,
			GA_RelVerify,				TRUE,
			GA_Text,					"Button 2",
		TAG_END),
		LAYOUT_AddChild,			Objects[GAD_BUTTON3]=NewObject(ButtonClass,NULL,
			GA_ID,						GAD_BUTTON3,
			GA_RelVerify,				TRUE,
			GA_Text,					"Button 3",
		TAG_END),
	EndHGroup))
		return(FALSE);
	else
		return(TRUE);

Start with the HGroupObject.
Go through a for(...) loop to make each button.
Finish with EndHGroup.

	if (!(Objects[GAD_BUTTONS_GROUP]=HGroupObject,
		LAYOUT_SpaceOuter,			TRUE,
		LAYOUT_SpaceInner,			TRUE,
 
	for(x=0; x<3; x++)
	{
		LAYOUT_AddChild,			Objects[x]=NewObject(ButtonClass,NULL,
			GA_ID,						x,
			GA_RelVerify,				TRUE,
			GA_Text,					Text[x],
		TAG_END),
	}
 
	EndHGroup))
		return(FALSE);
	else
		return(TRUE);

THEN...later on how would I add another button to the end, and remove a button.

Mon, 2015-01-12 10:31

salass00

Offline

Last seen: 7 months 2 weeks ago

Joined: 2011-02-03 11:27

You can use LAYOUT_AddChild

You can use LAYOUT_AddChild with SetAttrs():

if ((Objects[GAD_BUTTONS_GROUP] = HGroupObject,
    LAYOUT_SpaceOuter, TRUE,
    LAYOUT_SpaceInner, TRUE,
EndHGroup) != NULL)
{
    for(x = 0; x < 3; x++)
    {
        Objects[x] = NewObject(ButtonClass, NULL,
            GA_ID,        x,
            GA_RelVerify, TRUE,
            GA_Text,      Text[x],
        TAG_END);
        if (Objects[x] == NULL) {
            DisposeObject(Objects[GAD_BUTTONS_GROUP]);
            Objects[GAD_BUTTONS_GROUP] = NULL;
            return FALSE;
        }
        SetAttrs(Objects[GAD_BUTTONS_GROUP],
            LAYOUT_AddChild, Objects[x],
        TAG_END);
    }
    return TRUE;
}
return FALSE;

Mon, 2015-01-12 21:21

(Reply to #2) #3

mritter0

Offline

Last seen: 2 years 7 months ago

Joined: 2014-04-21 21:15

Thanks. I figured it out

Thanks. I figured it out after some sleep. Very similar to yours.

Mon, 2015-01-12 21:42

(Reply to #3) #4

mritter0

Offline

Last seen: 2 years 7 months ago

Joined: 2014-04-21 21:15

I changed the group settings

I changed the group settings to no space

			LAYOUT_InnerSpacing,		0,
			LAYOUT_LeftSpacing,			0,
			LAYOUT_RightSpacing,		0,
			LAYOUT_TopSpacing,			0,
			LAYOUT_BottomSpacing,		0,

When there is a button added to the group all is fine.

When there are no buttons added to the group, it still adds 2 vertical lines, even though the group is empty. Can a group have a space of 0 horiz and vert?

Wed, 2015-01-14 02:06

(Reply to #4) #5

mritter0

Offline

Last seen: 2 years 7 months ago

Joined: 2014-04-21 21:15

Actually it

Actually it is

			LAYOUT_AddChild,				Objects[TBG_LAYOUT]=NewObject(LayoutClass,NULL,
			LAYOUT_InnerSpacing,		0,
			LAYOUT_LeftSpacing,			0,
			LAYOUT_RightSpacing,		0,
			LAYOUT_TopSpacing,			0,
			LAYOUT_BottomSpacing,		0,

Can a LayoutClass not be 0x0 if nothing is in it?

Sun, 2015-05-10 01:32

(Reply to #5) #6

zzd10h

Offline

Last seen: 7 years 1 month ago

Joined: 2012-08-24 20:56

Hi, I'm a newbie in Reaction

Hi,
I'm a newbie in Reaction but I tried to use this snippet in my code without luck.

It displays only my fixed bitmap/buttons

IMAGE(http://zzd10h.amiga-ng.org/Divers/FastView_Capture_15-05-10_002744.JPG)
I tried too to DoMethod(win, WM_RETHINK);...

Thank you for your help

void make_window()
{
 win = NewObject(NULL, "window.class",         
        WINDOW_Position,       WPOS_CENTERSCREEN,
        WINDOW_Layout,         VLayoutObject,
 
 
         LAYOUT_AddChild,  OBJ(OBJ_BUT_GRP) = HGroupObject,
            LAYOUT_AddChild,  LayoutObject,
                LAYOUT_VertAlignment,  LALIGN_CENTER,
                LAYOUT_HorizAlignment, LALIGN_CENTER,
 
                LAYOUT_AddChild,  OBJ(OBJ_IBUT_1) = ButtonObject,
                    GA_ID,               OBJ_IBUT_1,
                    GA_RelVerify,        TRUE,                
                    BUTTON_BevelStyle,   BVS_NONE,
                    BUTTON_Transparent,  TRUE,
                    BUTTON_RenderImage,  OBJ(OBJ_SEL_1) = BitMapObject,
                        BITMAP_SourceFile,         "images/pdf",
                        BITMAP_DisabledSourceFile, "images/pdf_g",
                        BITMAP_Screen,             screen,
                        BITMAP_Masking,            TRUE,
                    BitMapEnd,
                    BUTTON_SelectImage,  OBJ(OBJ_UNSEL_1) = BitMapObject,
                        BITMAP_SourceFile,  "images/pdf_s",
                        BITMAP_Screen,      screen,
                        BITMAP_Masking,     TRUE,
                    BitMapEnd,
                ButtonEnd,
                LAYOUT_AddChild,  OBJ(OBJ_IBUT_2) = ButtonObject,
                    GA_ID,               OBJ_IBUT_2,
                    GA_RelVerify,        TRUE,                
                    BUTTON_BevelStyle,   BVS_NONE,
                    BUTTON_Transparent,  TRUE,
                    BUTTON_RenderImage,  OBJ(OBJ_SEL_2) = BitMapObject,
                        BITMAP_SourceFile,         "images/picture",
                        BITMAP_DisabledSourceFile, "images/picture_g",
                        BITMAP_Screen,             screen,
                        BITMAP_Masking,            TRUE,
                    BitMapEnd,
                    BUTTON_SelectImage,  OBJ(OBJ_UNSEL_2) = BitMapObject,
                        BITMAP_SourceFile,  "images/picture_s",
                        BITMAP_Screen,      screen,
                        BITMAP_Masking,     TRUE,
                    BitMapEnd,
                ButtonEnd,  
 
                LabelEnd,  
 
            LayoutEnd,
EndHGroup,
 
            CHILD_WeightedHeight, 0,
 
        End,   // VLayout
    WindowEnd;
 
int x = 0 ;
for(x = 0; x < 3; x++)
    {
        Objects[x] = NewObject(NULL, "button.gadget",
            GA_ID,x,
            GA_RelVerify, TRUE,
            GA_Text,"xxx",
            TAG_END);
 
        if (Objects[x] == NULL) 
        {
            DisposeObject(OBJ(OBJ_BUT_GRP));
            Objects[OBJ_BUT_GRP] = NULL;
            return ;
        }
        SetAttrs(OBJ(OBJ_BUT_GRP),
            LAYOUT_AddChild, Objects[x],
        TAG_END);
        printf("x %d \n",x);
    }
 
}

In this code, the first 2 fixed buttons are well displayed but not the 3 dynamic last ones.

Sun, 2015-05-10 11:57

(Reply to #6) #7

jabirulo

Offline

Last seen: 1 month 3 weeks ago

Joined: 2013-05-30 00:53

Hi I add a button to my

Hi I add a button to my already "created" ReAction window object (Object *win2;) this way:

struct Window *window2;
..
 win2 = IIntuition->NewObject(WindowClass, NULL,
..
 TAG_END);
 
 if(KM3) // if set add KEYMAP3 button
 {
  OBJ(OBJ_BTN3) = IIntuition->NewObject(ButtonClass, NULL,
                    GA_ID,         OBJ_BTN3,
                    GA_RelVerify,  TRUE,
                    GA_Underscore, ~0,
                    BUTTON_BevelStyle,  BVS_THIN,
                    //BUTTON_Transparent, TRUE,
                    BUTTON_RenderImage, OBJ(GID_KM3) = IIntuition->NewObject(BitMapClass, NULL,
                                IA_Width,    /*dd->size.width*/IMG_W + 8,
                                IA_Height,   /*dd->size.height*/IMG_H + 8,
                                IA_Scalable, dd->scaleflag > 1.0? TRUE:FALSE,
                                BITMAP_SourceFile, keymap2Flag,
                                BITMAP_Screen,     dd->scr,
                                BITMAP_Masking,    TRUE,
                                //BITMAP_Transparent,TRUE,
                    TAG_DONE),
                  TAG_DONE);
 
  if( !OBJ(GID_KM3) ) // language NOT valid/available
   IIntuition->SetAttrs(OBJ(OBJ_BTN3), GA_Text,dd->KeymapName[2], GA_Disabled,TRUE, TAG_DONE);
/*
  struct lmAddChild msg;
  msg.MethodID       = LM_ADDCHILD;
  msg.lm_Window      = window2;
  msg.lm_Object      = OBJ(OBJ_BTN3);
  msg.lm_ObjectAttrs = NULL;
  IIntuition->IDoMethodA(OBJ(OBJ_MAIN), (void*)&msg);
*/
  IIntuition->IDoMethod(OBJ(OBJ_MAIN), LM_ADDCHILD, window2, OBJ(OBJ_BTN3), NULL);
 }
..
if(win2)
 {
  if( (window2=(struct Window *)IIntuition->IDoMethod(win2, WM_OPEN, NULL)) )
..

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Sun, 2015-05-10 15:06

(Reply to #7) #8

zzd10h

Offline

Last seen: 7 years 1 month ago

Joined: 2012-08-24 20:56

Thank you very much,

IDoMethod(OBJ(OBJ_BUT_GRP), LM_ADDCHILD, window, OBJ(OBJ_BUT), NULL);
DoMethod(win, WM_RETHINK);

works well.

But it works only with fix name objects, not in a "for" loop with Objects[x].

Thank you again !

Sun, 2015-05-10 21:50

(Reply to #8) #9

zzd10h

Offline

Last seen: 7 years 1 month ago

Joined: 2012-08-24 20:56

Jabirulo fixed my

Jabirulo fixed my problem.

He changed
WINDOW_Layout, VLayoutObject,
by
WINDOW_Layout, OBJ(OBJ_MAIN) = NewObject(NULL, "layout.gadget"

IDoMethod(OBJ(OBJ_MAIN), LM_ADDCHILD, window, OBJ(OBJ_BTN), NULL);

Thank you very much, Javier, very kind :)

Sun, 2015-05-10 22:11

(Reply to #9) #10

thomas

Offline

Last seen: 1 week 5 days ago

Joined: 2011-05-16 14:23

But this adds the buttons to

But this adds the buttons to the vertical main group and not to the horizontal button group where they should appear.

Moreover LM_ADDCHILD is only needed if the window is already open. If you define the buttons before the window opens you can use SetAttrs as you did before.

Anyway here is a working example: http://thomas-rapp.homepage.t-online.de/examples/dyngrp.c

Mon, 2015-05-11 01:06

(Reply to #10) #11

zzd10h

Offline

Last seen: 7 years 1 month ago

Joined: 2012-08-24 20:56

Thank you for your help,

Thank you for your help, thomas.

It works well, buttons are well displayed horizontally or vertically by using the same
LAYOUT_Orientation for WINDOW_Layout and Button_Group layout.

WINDOW_Layout, OBJ(OBJ_MAIN) = NewObject(NULL, "layout.gadget",
LAYOUT_Orientation, LAYOUT_ORIENT_HORIZ,

LAYOUT_AddChild, OBJ(OBJ_BUT_GRP) = HGroupObject,
LAYOUT_AddChild, LayoutObject,
LAYOUT_Orientation, LAYOUT_ORIENT_HORIZ,

Mon, 2015-05-11 10:12

(Reply to #11) #12

thomas

Offline

Last seen: 1 week 5 days ago

Joined: 2011-05-16 14:23

If the main group is

If the main group is horizontal then your entire GUI is horizontal, you are not able to place objects below that group. And of course your OBJ_BUT_GRP group becomes superfluous because it remains empty.

Mon, 2015-05-11 23:19

(Reply to #12) #13

zzd10h

Offline

Last seen: 7 years 1 month ago

Joined: 2012-08-24 20:56

Yes, you are right for

Yes, you are right for OBJ_BUT_GRP... And unfortunately for me, you are right too for orientation...

My window is very simple, empty and HORIZontal

       WINDOW_Layout, OBJ(OBJ_MAIN) =NewObject(NULL, "layout.gadget",        
         LAYOUT_Orientation, LAYOUT_ORIENT_HORIZ, 
 
 
        End,

When I try to insert 2 objects vertically aligned in this window (even the "parent" VERT layout OBJ_LAYOUT is useless), they are displayed horizontally.

          OBJ(OBJ_LAYOUT) = NewObject(NULL,"layout.gadget",
			LAYOUT_Orientation, LAYOUT_ORIENT_VERT,                        
 				OBJ(OBJ_BTN) = NewObject(NULL, "button.gadget",
                    GA_ID,         LAST_NUM + x,
                    GA_RelVerify,        TRUE,                
                    BUTTON_BevelStyle,   BVS_NONE,
                    BUTTON_Transparent,  TRUE,
                    BUTTON_RenderImage,  iconProgramme->do_Gadget.GadgetRender,
                  TAG_DONE),
                  CHILD_Label,OBJ(OBJ_LBL) = NewObject(NULL, "button.gadget",
                  		GA_ReadOnly,    TRUE,
                  		GA_Text,	"XXX",
				  		BUTTON_BevelStyle,	BVS_NONE ,	
				  		BUTTON_Transparent,	TRUE,	
                  TAG_DONE),
          TAG_DONE);
 
	  	IDoMethod(OBJ(OBJ_MAIN), LM_ADDCHILD, window, OBJ(OBJ_LAYOUT), NULL);
	  	IDoMethod(OBJ(OBJ_MAIN), LM_ADDCHILD, window, OBJ(OBJ_BTN), NULL);
	  	IDoMethod(OBJ(OBJ_MAIN), LM_ADDCHILD, window, OBJ(OBJ_LBL), NULL);	 
or SetAttrs, same results.
 		SetAttrs(OBJ(OBJ_MAIN),LAYOUT_AddChild, OBJ(OBJ_LAYOUT),TAG_END);
		SetAttrs(OBJ(OBJ_MAIN),LAYOUT_AddChild, OBJ(OBJ_BTN),TAG_END);			
		SetAttrs(OBJ(OBJ_MAIN),LAYOUT_AddChild, OBJ(OBJ_LBL),TAG_END);

IMAGE(http://zzd10h.amiga-ng.org/Divers/Horiz.JPG)

Vertical orientation, all is OK
IMAGE(http://zzd10h.amiga-ng.org/Divers/Vertical.JPG)

Is somebody know a way to insert a VGroup in an HGroup window/Layout ?

Thank you by advance ;)

Tue, 2015-05-12 00:10

(Reply to #13) #14

thomas

Offline

Last seen: 1 week 5 days ago

Joined: 2011-05-16 14:23

See my example above.

Tue, 2015-05-12 01:26

(Reply to #14) #15

zzd10h

Offline

Last seen: 7 years 1 month ago

Joined: 2012-08-24 20:56

Certainly that I missed

Certainly that I missed something in your example, but I tried to reproduce it, it's the same problem.

My window is horizontal.
My objects are added horizontally. I would like that they were added by 2 by 2 vertically.

picture above his label | picture above his label | picture above his label ...

now there are

Following, I think, your example, I tried

	WINDOW_ParentGroup, VGroupObject,
 
 
	    LAYOUT_AddChild, OBJ(OBJ_MAIN) = HGroupObject,
						LAYOUT_SpaceOuter, FALSE,
						LAYOUT_EvenSize, TRUE,
            EndHGroup,
 
        End,   // VGroupObject
 
 
				OBJ(OBJ_BTN) = NewObject(NULL, "button.gadget",
                    GA_ID,         LAST_NUM + x,
                    GA_RelVerify,        TRUE,                
                    BUTTON_BevelStyle,   BVS_NONE,
                    BUTTON_Transparent,  TRUE,
                    BUTTON_RenderImage,  iconProgramme->do_Gadget.GadgetRender,
                  TAG_DONE),
                  CHILD_Label,OBJ(OBJ_LBL) = NewObject(NULL, "button.gadget",
                  		GA_ReadOnly,    TRUE,
                  		GA_Text,	tab_program_label[x],   
                  		BUTTON_TextPen, penText,                  		            		
				  		BUTTON_BevelStyle,	BVS_NONE ,	
				  		BUTTON_Transparent,	TRUE,	
                  TAG_DONE); 
 
			SetAttrs(OBJ(OBJ_MAIN),LAYOUT_AddChild, OBJ(OBJ_BTN),TAG_END);			
			SetAttrs(OBJ(OBJ_MAIN),LAYOUT_AddChild, OBJ(OBJ_LBL),TAG_END);

Thank you very much for your help.

Tue, 2015-05-12 10:07

(Reply to #15) #16

thomas

Offline

Last seen: 1 week 5 days ago

Joined: 2011-05-16 14:23

Ok, now I understand, I

Ok, now I understand, I didn't get your problem before.

A layout group can have only one orientation. If you want another orientation inside, you have to add another group or groups.

HGroup
  VGroup
    Button
    Label
  End
  VGroup
    Button
    Label
  End
  VGroup
    Button
    Label
  End
  ...
End

So what you have to do in your for() loop is to create a VGroup containing a Button and its Label and add that VGroup to the main HGroup.

Tue, 2015-05-12 12:39

(Reply to #16) #17

zzd10h

Offline

Last seen: 7 years 1 month ago

Joined: 2012-08-24 20:56

Is it not what I tried here

Is it not what I tried here ?
http://www.os4coding.net/forum/create-buttons-loop#comment-2284

In this code, I added the 3 objects (VLayout, Button and Label) but I had tried to add only the VLayout without more luck.

Thank you for your patience.

Tue, 2015-05-12 18:58

(Reply to #17) #18

thomas

Offline

Last seen: 1 week 5 days ago

Joined: 2011-05-16 14:23

This code does some bad

This code does some bad things.

The first thing is very bad. You add the same buttons to two groups. This cannot work. An object can only be part of one group at a time. If you add it to another group without removing it first, it corrupts list pointers. It's pure luck that your test didn't crash.

The second thing you probably didn't notice or drew the wrong conclusion. You use a button object with CHILD_Label. This cannot work, either. CHILD_Label expects to get an object of a sub-class of imageclass, but buttons are objects of gadgetclass (that's why it's called button.gadget and not button.image).

If you want to use a button as a label, you should use LAYOUT_AddChild. If you insist on CHILD_Label, then you should use label.image instead of button.gadget.

But using CHILD_Label is part of your problem. Layout.gadget places the CHILD_Label always left or right of the object (depending on the value of LAYOUT_LabelColumn), never above or below. If you want the text to respect LAYOUT_Orientation, you have to use LAYOUT_AddChild or LAYOUT_AddImage (depending on whether you want to add a gadget or an image object).

Here is a new example with icons and labels below them: http://thomas-rapp.homepage.t-online.de/examples/iconbar.c

Tue, 2015-05-12 20:37

(Reply to #18) #19

zzd10h

Offline

Last seen: 7 years 1 month ago

Joined: 2012-08-24 20:56

Thank you very much Thomas

Thank you very much Thomas for your explanations and example.

Using it,

		if ( ( OBJ(OBJ_BTN) = (APTR) VGroupObject,
				LAYOUT_AddChild, ButtonObject,
                    	                GA_ID,               LAST_NUM + x,
                 	   	        GA_RelVerify,        TRUE,   
               	     	                BUTTON_BevelStyle,   BVS_NONE,
                	                BUTTON_Transparent,  TRUE,                  
					BUTTON_RenderImage,  iconProgramme->do_Gadget.GadgetRender,
					EndObject,   
				LAYOUT_AddChild, ButtonObject,
                  		        GA_ReadOnly,    TRUE,
                  		        GA_Text,	tab_program_label[x],   
				  	BUTTON_BevelStyle,	BVS_NONE ,	
				  	BUTTON_Transparent,	TRUE,	
					EndObject,						  						
				EndVGroup)) 
				{	    	    
					SetAttrs(OBJ(OBJ_MAIN),LAYOUT_AddChild, OBJ(OBJ_BTN),TAG_END);	    
	    		        }

It works !

IMAGE(http://zzd10h.amiga-ng.org/Divers/FastView_Capture_15-05-12_192619.JPG)

Search form

User login