Template usage ReadArgs

Wed, 2014-11-05 01:01

#2

jabirulo

Offline

Last seen: 3 weeks 1 day ago

Joined: 2013-05-30 00:53

Maybe you have some typo in

Maybe you have some typo in your code ;-)
Can you post the ReadArgs() codelines you're using?

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Wed, 2014-11-05 08:31

(Reply to #2) #3

JosDuchIt

Offline

Last seen: 8 years 1 week ago

Joined: 2012-01-08 20:57

I have this #define

I have this

#define __USE_INLINE__
//#define __USE_BASETYPE__
#include <exec/types.h>
#include <proto/intuition.h>
#include <proto/utility.h>
#include <intuition/intuition.h> 
#include <proto/dos.h> //Printf
#include <stdio.h>
#include <string.h>
 
#define TEMPLATE "WINDOW/A,SCREEN/K, ACTIVE/S" // if screen not mentioned Workbench
 
int main(int argc, char *argv[]) 
{
	char scrnname[MAXPUBSCREENNAME+1]; //= ""; "Workbench"; //default pubscreen
	scrnname[0] = 0;
	char winnamesh[31];
	LONG	args[] = { 0, 0};
	BOOL active = FALSE;
	struct RDArgs *rdargs;
   int RC = RETURN_FAIL;
	struct Window *win;
	rdargs = ReadArgs(TEMPLATE,args, NULL);
	if (rdargs)
	{ 
		if (args[0]) strncpy (winnamesh, (char *)args[0] , 30); //OK  windowname abbreviated to 30 characters (if more) 
		if (args[1]) strncpy (scrnname, (char *)args[1], MAXPUBSCREENNAME);
		if (args[2]) {active = args[2];}
		if(active)
		{}
		else
		{}
	} //rdargs
	else
	{
	PrintFault(IoErr(), NULL);
   	Printf("usage: %s\n",TEMPLATE);
	}
 FreeArgs(rdargs);
 return (RC); 
}

Wed, 2014-11-05 10:20

(Reply to #3) #4

salass00

Offline

Last seen: 6 months 2 weeks ago

Joined: 2011-02-03 11:27

Try removing the space in the

Try removing the space in the TEMPLATE string before "ACTIVE/S".

Also some other unrelated notes:

Don't use strncpy()/strncat() unless you really need their weird behaviors for some reason, use the more sane strlcpy()/strlcat() instead (these are also available in utility.library as Strlcpy() and Strlcat() BTW).

Your args array has only room for two elements yet you need room for three. Also I suggest defining the arg indexes as an enum rather than hardcoding the numbers directly in your code:

enum {
    ARG_WINDOW,
    ARG_SCREEN,
    ARG_ACTIVE,
    NUM_ARGS
};

Then you can define your args array simply as:

LONG args[NUM_ARGS] = {0};

Wed, 2014-11-05 10:27

(Reply to #4) #5

OldFart

Offline

Last seen: 3 months 2 weeks ago

Joined: 2010-11-30 14:09

@JosDuchIt Again, IIRC the

@JosDuchIt

Again, IIRC the problem is in this line:

#define TEMPLATE "WINDOW/A,SCREEN/K, ACTIVE/S"

where there is a space between a comma and a keyword.

There may be a space leading the comma, but not trailing.

Years ago I've constructed some testing examples about some DOS-functions, o.a. concerning ReadArgs(). It has been long since, but I think they're to be found in this archive: http://www.os4depot.net/index.php?function=showfile&file=development/example/dostutorials.lha

Hope I could help you out

OldFart

P.s.: ever thought of 'just in time' declaration of variables? You declare them first thing in this function, but as the function 'ReadArgs()' fails, they've been declared for naught.
Same goes for FreeArgs(), which is called whether ReadArgs() returns fine or not. It only needs to be called when ReadArgs() returns with a value.

Wed, 2014-11-05 21:27

#6

JosDuchIt

Offline

Last seen: 8 years 1 week ago

Joined: 2012-01-08 20:57

@all thanks for the hints

@all

thanks for the hints

Wed, 2014-11-05 21:41

(Reply to #6) #7

JosDuchIt

Offline

Last seen: 8 years 1 week ago

Joined: 2012-01-08 20:57

@Oldfart ever thought of

@Oldfart

ever thought of 'just in time' declaration of variables?

Not yet. I am a "one-pogram" maintainer & i copied the style from the source i inherited.

There are some advantages to this style too:
i can easily enter (copying) debugging statements without worrying if the variables are blocklocal
as i am coding on my SAM without a debugger, it saves me time.

It is easier too see what variables are used too.
I am a bit lazy probably.

Wed, 2014-11-05 22:08

(Reply to #7) #8

JosDuchIt

Offline

Last seen: 8 years 1 week ago

Joined: 2012-01-08 20:57

@salas00 Using the enum: I

@salas00
Using the enum: I don't quite see how to modify my source. This is how it looks now. (Works OK.)
Could you modify it as you suggest? Thanks in advance.

The new template works fine
examples:
getsizes W NotePad S OrigynWebBrowser // ok
getsizes S OrigynWebBrowser // no active window there
getsizes S Workbench // my active shell
getsizes W "" S Workbench // my active shell
getsizes W CM.gc // ok

* compiles and runs, use  -lauto  */
/* aka JosDuchIt */
 
#define __USE_INLINE__
//#define __USE_BASETYPE__
#include <exec/types.h>
#include <proto/intuition.h>
#include <proto/utility.h>
#include <intuition/intuition.h> 
#include <proto/dos.h> //Printf
#include <stdio.h>
#include <string.h>
 
#define TEMPLATE "W=WINDOW/K,S=SCREEN/K" 
// if screen not mentioned Workbench
// if window not mentioned active window
 
struct Window * get_window( STRPTR , STRPTR ) ;
struct Window * get_active( STRPTR) ;
 
BOOL print_wsizes(struct Window *) ;
 
BOOL print_wsizes(struct Window *win)
{
	//struct Window  *win=NULL;
	printf("%s\n", " Title LeftEdge TopEdge Width Height MinWidht MinHeight GZZWidth GZZHeight "); //Mouse X,y GEEX,Y ??
	printf("%s\n", win->Title);  /// crash
	printf("%ld\n",win->LeftEdge);
	printf("%ld\n",win->TopEdge);
	printf("%ld\n",win->Width);
	printf("%ld\n",win->Height);
	printf("%ld\n",win->MinWidth);
	printf("%ld\n",win->MinHeight);
	printf("%ld\n",win->GZZWidth);
	printf("%ld\n",win->GZZHeight);
	return (TRUE);
}
 
struct Window *get_window (STRPTR screenname, STRPTR windowabbrev)
{
	struct Window *win = NULL;
 
	if (windowabbrev)
	{
		long abbrlen = strlen(windowabbrev);
		struct Screen *scr;
 
		if (scr = LockPubScreen (screenname && !screenname[0] ? NULL : screenname))
		{
			for (win = scr->FirstWindow; win; win = win->NextWindow)
			{
				if (win->Title && !Strnicmp(win->Title,windowabbrev,abbrlen))
				break;
			}
			UnlockPubScreen (NULL,scr);
		}
	}
return (win);
}
 
 
struct Window *get_active (STRPTR screenname)
{
	struct Window *win = NULL;
	struct Screen *scr = NULL;
	ULONG  ib;
	if (scr = LockPubScreen (screenname && !screenname[0] ? NULL : screenname))
	{
		ib  = LockIBase(0);
                win = ((struct IntuitionBase *)IntuitionBase)->ActiveWindow; //OS4E was IntuitionBase->ActiveWindow; //OS4E 
                UnlockIBase(ib);
                 //if (wn && wn->Title) strncpy (buff, wn->Title, bfsize)
	}
	return (win);
}
 
 
int main(int argc, char *argv[]) 
{
	char scrnname[MAXPUBSCREENNAME+1]; //= ""; "Workbench"; //default pubscreen
	scrnname[0] = 0;
	char winnamesh[31];
	LONG	args[] = { 0, 0};
	BOOL active = FALSE;
	struct RDArgs *rdargs;
   	int RC = RETURN_FAIL;
	struct Window *win;
	rdargs = ReadArgs(TEMPLATE,args, NULL);
	if (rdargs)
	{ 
		if (args[0]) 
		{
			strncpy (winnamesh, (char *)args[0] , 30); //OK  windowname abbreviated to 30 characters (if more) 
		}
		else 
		{
			active =TRUE;
		}
 
		if (args[1]) strncpy (scrnname, (char *)args[1], MAXPUBSCREENNAME); // test for existing screenname 
		if(active)
		{
			if (win = get_active((STRPTR)scrnname)) 
			{
				print_wsizes(win);
				RC = RETURN_OK;
			} 
		}
		else   // WINDOW/K used
		{ 
			if ((winnamesh) && (winnamesh[0]))  /// check for empty ?? if empty=>active window
			{	
				if (win = get_window((STRPTR)scrnname, (STRPTR)winnamesh))  //screename or windowname may be wrong
				{
					print_wsizes(win);
					RC = RETURN_OK;
				}
				else
				{ 
					printf("No window %s or screen %s found, Case correct?\n", winnamesh,scrnname);
				}
			}
			else
			{
				if (win = get_active((STRPTR)scrnname))  
				{
				print_wsizes(win);
				RC = RETURN_OK;
				}
			}
		}
	} //rdargs
	else
	{
	PrintFault(IoErr(), NULL);
	printf("usage: %s\n",TEMPLATE);
	}
 FreeArgs(rdargs);
 return (RC); 
}
 
</cod>

Thu, 2014-11-06 12:20

(Reply to #8) #9

salass00

Offline

Last seen: 6 months 2 weeks ago

Joined: 2011-02-03 11:27

I rewrote your getsizes

I rewrote your getsizes program for you as you asked me to:
https://dl.dropboxusercontent.com/u/26599983/getsizes.c

I removed the scrnname parameter from the get_active() function as it was not used for anything meaningful. I also made the window list scanning and window structure reading safer by surrounding this whole code section with LockIBase()/UnlockIBase() which in turn made it necessary to copy the data into a temporary data structure (struct WindowData) for printing later with print_wdata().

I also added the commandline I used for compiling to the source code. I recommend always using the following options "-Wall -Werror -Wwrite-strings" when compiling your own code using gcc. The -Wall and -Wwrite-strings are for enabling useful compiler warnings and the -Werror makes the compiler treat them as errors (especially useful when building larger projects where it can be easy to miss some warnings if there are a lot of different files to compile).

Thu, 2014-11-06 17:21

(Reply to #9) #10

JosDuchIt

Offline

Last seen: 8 years 1 week ago

Joined: 2012-01-08 20:57

@salass00 Thanks for help &

@salass00

Thanks for help & friendly coding lesson

Search form

User login