OK THX , so good code should be if program is iconified/hidden it should remove/close all stuff related to window/screen like pens, ¿menus (pointers to "old" window/screen)? and such?

TIA

THX. I think I removed all the "naughty" screenlocks. Now time to change'em to use GetScreenAttrs(). And obtain/release pens seems ok now too.

Next work is see/check image loading/disposing. It seems if I remove/rename some of the images Mixer uses, on uniconifying/showing Mixer again it boombs :-P
BTW is it a good idea to lock such files while mixer is showing and unlock them on iconify/hide?
TIA

BTW: can someone show me how to use 'GetScreenAttrs()' instead of 'LockPubScreen()' in this part of code, or is just nonsense and is ok to lock/unlock screen (is a local variable) in this case:

...
 MainScreen = LockPubScreen(NULL);
 if( ARG("IMAGEPATH") ) strcpy(NameWithPath, ARG("IMAGEPATH"));
 else strcpy(NameWithPath, "Images/");
 AddPart(NameWithPath, FileName, 1024);
 if( (o = NewDTObject( (char *)NameWithPath,
                       DTA_GroupID, GID_PICTURE,
                       OBP_Precision, PRECISION_IMAGE,
                       PDTA_Remap, TRUE,
                       PDTA_Screen, MainScreen,
                       PDTA_FreeSourceBitMap, TRUE,
                       PDTA_UseFriendBitMap, TRUE,
                       PDTA_DestMode, PMODE_V43,
                      TAG_END)) )
 {
    modeid = GetVPModeID( &(MainScreen->ViewPort) );
    if( GetDisplayInfoData(NULL, (APTR)&di, sizeof(struct DisplayInfo),
                           DTAG_DISP, modeid) )
    {
     fri.fri_PropertyFlags = di.PropertyFlags;
     fri.fri_Resolution = *(&di.Resolution);
     fri.fri_RedBits = di.RedBits;
     fri.fri_GreenBits = di.GreenBits;
     fri.fri_BlueBits = di.BlueBits;
     fri.fri_Dimensions.Depth = MainScreen->BitMap.Depth;
     fri.fri_Screen = MainScreen;
     fri.fri_ColorMap = MainScreen->ViewPort.ColorMap;
    }
...
 }
 
UnlockPubScreen(NULL, MainScreen);
...

OK. Yes Mixer uses intuition/gadtools :-/ The screen lock/unlock seems solved the way I have it now (no golbal pointers to screen). I can change screenmode without problems.

2 (and half) more questions:
1)Is it safe to use malloc() [newlib i think] or is there an AOS4 substitute?

2)It seems if I remove/rename some of the images (or dir) Mixer uses, on (un)iconifying Mixer GR/boombs :-P as Mixer tries to 'Dispose(object)'.
BTW is it a good idea to lock such files/dir while mixer is showing and unlock them to provent user rename/delete such files/dir while Mixer is running?
2b)Will Lock/UnLock solve me that issue?

TIA

OK. While Mixer is showing its window I can rename/delete images/dir so there is no Lock on such files.

IIRC Mixer does DisposeObject() before iconifying ... well it seems not :-P ('cos it crashes/GR) will have to check such code.

TIA

Hi, added an iconify gadget via sysclass and ¿buttonclass? (don't remember now).
Changed global screen var to be local (and using only when I have to). Now it (un)inconifies without problem, even can change screenmodes and everything is fine.
The problem with image loading/disposing is solved too, just have to clean/NULL some variables that weren't before.
Will upload Mixer to os4depot ASAP.

BTW THX for all the help! :-)

:-D
Just a "cosmetic" thing how to make main window (uses gadtools/intuition) not aware of clicks/mousewheel/etc. when for example showing the about window.
I'm using ' SetWindowPointer(MixWindow, WA_BusyPointer, TRUE, TAG_END);' to change mouse icon, but main window still acts on mouse clicks and such.
Is there some sort of 'SetWindowAttr(MixWindow, SLEEP)'?
Or somekind of SetWindowAttr(MixWindow IDCMP_Flags, NULL); and re-enabling them when about window closes.

TIA.

THX thoma, just updated with not deprecated OS4.1 functions:

if( (lock = AllocVecTags(sizeof(struct Requester), AVT_Type,MEMF_SHARED, AVT_ClearWithValue,0, TAG_DONE)) )

and

FreeVec(lock);

Hope they are OK. Works flawlessly!!! :-)

Yep, thx I already read it, but as you see didn't understand quite well.
Will read it again and make changes on my code if necessary.
If I use a memory allocation for temporary "objects", I should use MFM_PRIVATE?
OK going to read the wiki again THX.